[lib] Introduce a special role for Admins
ClosedPublic
Actions

Authored by rohan on Nov 28 2023, 10:39 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Dec 26, 8:58 PM

	Unknown Object (File)
	Mon, Dec 16, 4:37 PM

	Unknown Object (File)
	Mon, Dec 16, 4:37 PM

	Unknown Object (File)
	Mon, Dec 16, 4:36 PM

	Unknown Object (File)
	Mon, Dec 16, 4:36 PM

	Unknown Object (File)
	Fri, Nov 29, 6:15 PM

	Unknown Object (File)
	Nov 26 2024, 6:26 AM

	Unknown Object (File)
	Nov 23 2024, 6:30 AM

View All 89 Files

Subscribers

ashoat

Details

Reviewers

atul
ginsu
tomek

Commits

rCOMMa011993dc8a0: [lib] Introduce a special role for Admins

Summary

We now introduce an enum that maps an ADMIN_ROLE to a number, similar to DEFAULT_ROLE

Addresses ENG-5835

Test Plan

N/A, tested in the next diff

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Nov 28 2023, 10:39 AM

Herald added a subscriber: ashoat. · View Herald TranscriptNov 28 2023, 10:39 AM

rohan edited the summary of this revision. (Show Details)Nov 28 2023, 10:40 AM

Harbormaster completed remote builds in B24578: Diff 33954.Nov 28 2023, 10:59 AM

rohan requested review of this revision.Nov 28 2023, 10:59 AM

rohan added a child revision: D10076: [keyserver] Run migration to populate special_role column for Admins.Nov 28 2023, 11:32 AM

atul accepted this revision.Nov 28 2023, 1:37 PM

This revision is now accepted and ready to land.Nov 28 2023, 1:37 PM

Closed by commit rCOMMa011993dc8a0: [lib] Introduce a special role for Admins (authored by rohan). · Explain WhyNov 29 2023, 6:06 PM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMMa011993dc8a0: [lib] Introduce a special role for Admins.

Revision Contents
Changeset List

Path

Size

lib/

permissions/

special-roles.js

2 lines

Diff 34015

View Options

lib/permissions/special-roles.js

[lib] Introduce a special role for AdminsClosedPublicActions