Page MenuHomePhabricator
Differential D10076

[keyserver] Run migration to populate special_role column for Admins
ClosedPublic
Actions

Authored by rohan on Nov 28 2023, 11:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Feb 27, 7:24 PM
Unknown Object (File)
Thu, Feb 27, 7:15 PM
Unknown Object (File)
Thu, Feb 27, 7:15 PM
Unknown Object (File)
Wed, Feb 26, 6:43 AM
Unknown Object (File)
Sun, Feb 23, 10:18 PM
Unknown Object (File)
Tue, Feb 18, 6:38 AM
Unknown Object (File)
Jan 26 2025, 3:37 AM
Unknown Object (File)
Jan 20 2025, 12:21 PM
View All 72 Files
Subscribers
ashoat

Details

Reviewers
atul
ginsu
tomek
Commits
rCOMM11ae2a8c39ac: [keyserver] Run migration to populate special_role column for Admins
Summary

Now that we have a specialRoles.ADMIN_ROLE enum, we should populate existing Admins in MariaDB to have this value in their special_role field. Following D9974, we already support populating new Admin's special_role field, so we don't need to worry about that.

There are two decent ways to check for an Admins role, either by role.name === Admins or roleIsAdminRole. The latter is a little more difficult since it requires us to construct RoleInfo to pass it in roleIsAdminRole, and makes it overall difficult to do a simple UPDATE statement. That's why I opted to do it through the first method (checking name)>

Addresses ENG-5837

Depends on D10075

Test Plan

Checked the MariaDB table after the migration and confirmed the Admins roles had the special_role field

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
database/
12 lines

Diff 34016

View Options

keyserver/src/database/migration-config.js

Show First 20 Lines • Show All 298 Lines • ▼ Show 20 Linesbool add_not_null_constraint_to_metadata(sqlite3 *db) {
stringStream << "Error adding NOT NULL constraint to metadata table: " stringStream << "Error adding NOT NULL constraint to metadata table: "
<< error; << error;
Logger::log(stringStream.str()); Logger::log(stringStream.str());
sqlite3_free(error); sqlite3_free(error);
return false; return false;
} }
bool add_avatar_column_to_threads_table(sqlite3 *db) {
char *error;
sqlite3_exec(
db,
"ALTER TABLE threads ADD COLUMN avatar TEXT;",
nullptr,
nullptr,
&error);
if (!error) {
return true;
}
std::ostringstream stringStream;
stringStream << "Error adding avatar column to threads table: " << error;
Logger::log(stringStream.str());
sqlite3_free(error);
return false;
}
bool create_schema(sqlite3 *db) { bool create_schema(sqlite3 *db) {
char *error; char *error;
sqlite3_exec( sqlite3_exec(
db, db,
"CREATE TABLE IF NOT EXISTS drafts (" "CREATE TABLE IF NOT EXISTS drafts ("
" key TEXT UNIQUE PRIMARY KEY NOT NULL," " key TEXT UNIQUE PRIMARY KEY NOT NULL,"
" text TEXT NOT NULL" " text TEXT NOT NULL"
");" ");"
Show All 37 Lines sqlite3_exec(
" creation_time BIGINT NOT NULL," " creation_time BIGINT NOT NULL,"
" parent_thread_id TEXT," " parent_thread_id TEXT,"
" containing_thread_id TEXT," " containing_thread_id TEXT,"
" community TEXT," " community TEXT,"
" members TEXT NOT NULL," " members TEXT NOT NULL,"
" roles TEXT NOT NULL," " roles TEXT NOT NULL,"
" current_user TEXT NOT NULL," " current_user TEXT NOT NULL,"
" source_message_id TEXT," " source_message_id TEXT,"
" replies_count INTEGER NOT NULL" " replies_count INTEGER NOT NULL,"
" avatar TEXT"
");" ");"
"CREATE TABLE IF NOT EXISTS metadata (" "CREATE TABLE IF NOT EXISTS metadata ("
" name TEXT UNIQUE PRIMARY KEY NOT NULL," " name TEXT UNIQUE PRIMARY KEY NOT NULL,"
" data TEXT NOT NULL" " data TEXT NOT NULL"
");" ");"
"CREATE INDEX IF NOT EXISTS media_idx_container" "CREATE INDEX IF NOT EXISTS media_idx_container"
▲ Show 20 Lines • Show All 225 Lines • ▼ Show 20 Linesstd::vector<std::pair<uint, SQLiteMigration>> migrations{
{17, {recreate_messages_table, true}}, {17, {recreate_messages_table, true}},
{18, {create_messages_idx_thread_time, true}}, {18, {create_messages_idx_thread_time, true}},
{19, {create_media_idx_container, true}}, {19, {create_media_idx_container, true}},
{20, {create_threads_table, true}}, {20, {create_threads_table, true}},
{21, {update_threadID_for_pending_threads_in_drafts, true}}, {21, {update_threadID_for_pending_threads_in_drafts, true}},
{22, {enable_write_ahead_logging_mode, false}}, {22, {enable_write_ahead_logging_mode, false}},
{23, {create_metadata_table, true}}, {23, {create_metadata_table, true}},
{24, {add_not_null_constraint_to_drafts, true}}, {24, {add_not_null_constraint_to_drafts, true}},
{25, {add_not_null_constraint_to_metadata, true}}}}; {25, {add_not_null_constraint_to_metadata, true}},
{26, {add_avatar_column_to_threads_table, true}}}};
enum class MigrationResult { SUCCESS, FAILURE, NOT_APPLIED }; enum class MigrationResult { SUCCESS, FAILURE, NOT_APPLIED };
MigrationResult applyMigrationWithTransaction( MigrationResult applyMigrationWithTransaction(
sqlite3 *db, sqlite3 *db,
const MigrateFunction &migrate, const MigrateFunction &migrate,
int index) { int index) {
sqlite3_exec(db, "BEGIN TRANSACTION;", nullptr, nullptr, nullptr); sqlite3_exec(db, "BEGIN TRANSACTION;", nullptr, nullptr, nullptr);
▲ Show 20 Lines • Show All 184 Lines • ▼ Show 20 Lines static auto storage = make_storage(
make_column("creation_time", &Thread::creation_time), make_column("creation_time", &Thread::creation_time),
make_column("parent_thread_id", &Thread::parent_thread_id), make_column("parent_thread_id", &Thread::parent_thread_id),
make_column("containing_thread_id", &Thread::containing_thread_id), make_column("containing_thread_id", &Thread::containing_thread_id),
make_column("community", &Thread::community), make_column("community", &Thread::community),
make_column("members", &Thread::members), make_column("members", &Thread::members),
make_column("roles", &Thread::roles), make_column("roles", &Thread::roles),
make_column("current_user", &Thread::current_user), make_column("current_user", &Thread::current_user),
make_column("source_message_id", &Thread::source_message_id), make_column("source_message_id", &Thread::source_message_id),
make_column("replies_count", &Thread::replies_count)), make_column("replies_count", &Thread::replies_count),
make_column("avatar", &Thread::avatar)),
make_table( make_table(
"metadata", "metadata",
make_column("name", &Metadata::name, unique(), primary_key()), make_column("name", &Metadata::name, unique(), primary_key()),
make_column("data", &Metadata::data))); make_column("data", &Metadata::data)));
storage.on_open = on_database_open; storage.on_open = on_database_open;
return storage; return storage;
} }
▲ Show 20 Lines • Show All 298 Lines • Show Last 20 Lines