Page MenuHomePhabricator

[keyserver/lib] Populate special_role field when initial roles are created
ClosedPublic

Authored by rohan on Nov 24 2023, 9:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Oct 26, 4:47 PM
Unknown Object (File)
Oct 2 2024, 4:13 AM
Unknown Object (File)
Oct 2 2024, 4:13 AM
Unknown Object (File)
Oct 2 2024, 4:13 AM
Unknown Object (File)
Oct 2 2024, 4:12 AM
Unknown Object (File)
Oct 2 2024, 4:09 AM
Unknown Object (File)
Aug 28 2024, 11:54 AM
Unknown Object (File)
Aug 26 2024, 3:11 PM
Subscribers

Details

Summary

Now that we've createde a roles.special_role column in MariaDB and wrote a migration that populates it for existing threads, we should make sure new threads going forward populate this upon creation.

Depends on D9961

Part of ENG-5833

Test Plan

Create some new communities and make sure the special_role is populated for Members (no special role for Admins yet)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

keyserver/src/creators/role-creator.js
54 ↗(On Diff #33600)

Best to opt for ?? over || when possible

This revision is now accepted and ready to land.Nov 27 2023, 12:51 AM