Page MenuHomePhabricator
Differential D9974

[keyserver/lib] Populate special_role field when initial roles are created
ClosedPublic
Actions

Authored by rohan on Nov 24 2023, 9:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 11:53 AM
Unknown Object (File)
Mon, Mar 31, 10:24 AM
Unknown Object (File)
Mon, Mar 31, 9:18 AM
Unknown Object (File)
Sun, Mar 30, 11:34 PM
Unknown Object (File)
Sun, Mar 30, 3:52 PM
Unknown Object (File)
Mar 2 2025, 5:31 AM
Unknown Object (File)
Feb 27 2025, 7:24 PM
Unknown Object (File)
Feb 27 2025, 7:24 PM
View All 96 Files
Subscribers
ashoat

Details

Reviewers
atul
ginsu
tomek
Commits
rCOMM4948dcde64ba: [keyserver/lib] Populate special_role field when initial roles are created
Summary

Now that we've createde a roles.special_role column in MariaDB and wrote a migration that populates it for existing threads, we should make sure new threads going forward populate this upon creation.

Depends on D9961

Part of ENG-5833

Test Plan

Create some new communities and make sure the special_role is populated for Members (no special role for Admins yet)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rohan created this revision.Nov 24 2023, 9:47 AM
Herald added a subscriber: ashoat. · View Herald TranscriptNov 24 2023, 9:47 AM
rohan added a child revision: D9975: [keyserver] Update usage of threads.default_role in role-deleters.js.Nov 24 2023, 9:49 AM
rohan edited the test plan for this revision. (Show Details)Nov 24 2023, 10:02 AM
Harbormaster completed remote builds in B24401: Diff 33600.Nov 24 2023, 10:21 AM
rohan requested review of this revision.Nov 24 2023, 10:21 AM
ashoat added inline comments.Nov 26 2023, 3:34 PM
keyserver/src/creators/role-creator.js
54 ↗(On Diff #33600)

Best to opt for ?? over || when possible

tomek accepted this revision.Nov 27 2023, 12:51 AM
This revision is now accepted and ready to land.Nov 27 2023, 12:51 AM
rohan updated this revision to Diff 33726.Nov 27 2023, 6:17 AM

Use ?? over ||

Harbormaster completed remote builds in B24520: Diff 33726.Nov 27 2023, 9:25 AM
Closed by commit rCOMM4948dcde64ba: [keyserver/lib] Populate special_role field when initial roles are created (authored by rohan). · Explain WhyNov 27 2023, 10:36 AM
This revision was automatically updated to reflect the committed changes.
rohan added a commit: rCOMM4948dcde64ba: [keyserver/lib] Populate special_role field when initial roles are created.
rohan mentioned this in D10076: [keyserver] Run migration to populate special_role column for Admins.Nov 28 2023, 11:32 AM
rohan mentioned this in rCOMM11ae2a8c39ac: [keyserver] Run migration to populate special_role column for Admins.Nov 29 2023, 6:06 PM

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
7 lines
lib/
permissions/
4 lines

Diff 33752

View Options

keyserver/src/creators/role-creator.js

  • This file was added.
// @flow
import { processReportStoreOperations } from './report-store-ops.js';
import {
type ClientReportCreationRequest,
reportTypes,
} from '../types/report-types.js';
const defaultReport = {
type: reportTypes.MEDIA_MISSION,
time: Date.now(),
mediaMission: {
steps: [],
result: { success: true },
totalTime: 0,
userTime: 0,
},
};
const defaultMockReportWeb = {
platformDetails: { platform: 'web' },
...defaultReport,
};
const defaultMockReportIos = {
platformDetails: { platform: 'ios' },
...defaultReport,
};
const mockReports: $ReadOnlyArray<ClientReportCreationRequest> = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportWeb,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const sortReports = (
queuedReports: $ReadOnlyArray<ClientReportCreationRequest>,
): $ReadOnlyArray<ClientReportCreationRequest> => {
return [...queuedReports].sort(
(a: ClientReportCreationRequest, b: ClientReportCreationRequest) =>
a.id.localeCompare(b.id),
);
};
describe('processReportStoreOperations', () => {
it('should return the original reports if no operations are processed', () => {
const reportStoreOps = [];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(mockReports);
});
it('should replace the report with the given id', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportIos,
id: '2',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportIos,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(sortReports(processedReports)).toEqual(sortReports(expectedReports));
});
it('should handle an empty reports with replace operation', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportWeb,
id: '1',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual(expectedReports);
});
it('should remove reports with given ids', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(expectedReports);
});
it('should handle empty reports with remove_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
it('should remove all reports', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual([]);
});
it('should handle empty reports with remove_all_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
});
View Options

lib/permissions/special-roles.js

  • This file was added.
// @flow
import { processReportStoreOperations } from './report-store-ops.js';
import {
type ClientReportCreationRequest,
reportTypes,
} from '../types/report-types.js';
const defaultReport = {
type: reportTypes.MEDIA_MISSION,
time: Date.now(),
mediaMission: {
steps: [],
result: { success: true },
totalTime: 0,
userTime: 0,
},
};
const defaultMockReportWeb = {
platformDetails: { platform: 'web' },
...defaultReport,
};
const defaultMockReportIos = {
platformDetails: { platform: 'ios' },
...defaultReport,
};
const mockReports: $ReadOnlyArray<ClientReportCreationRequest> = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportWeb,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const sortReports = (
queuedReports: $ReadOnlyArray<ClientReportCreationRequest>,
): $ReadOnlyArray<ClientReportCreationRequest> => {
return [...queuedReports].sort(
(a: ClientReportCreationRequest, b: ClientReportCreationRequest) =>
a.id.localeCompare(b.id),
);
};
describe('processReportStoreOperations', () => {
it('should return the original reports if no operations are processed', () => {
const reportStoreOps = [];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(mockReports);
});
it('should replace the report with the given id', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportIos,
id: '2',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
{
...defaultMockReportIos,
id: '2',
},
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(sortReports(processedReports)).toEqual(sortReports(expectedReports));
});
it('should handle an empty reports with replace operation', () => {
const reportStoreOps = [
{
type: 'replace_report',
payload: {
report: {
...defaultMockReportWeb,
id: '1',
},
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '1',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual(expectedReports);
});
it('should remove reports with given ids', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const expectedReports = [
{
...defaultMockReportWeb,
id: '3',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual(expectedReports);
});
it('should handle empty reports with remove_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_reports',
payload: {
ids: ['1', '2'],
},
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
it('should remove all reports', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations(
mockReports,
reportStoreOps,
);
expect(processedReports).toEqual([]);
});
it('should handle empty reports with remove_all_reports operation', () => {
const reportStoreOps = [
{
type: 'remove_all_reports',
},
];
const processedReports = processReportStoreOperations([], reportStoreOps);
expect(processedReports).toEqual([]);
});
});