Details
Details
Tested both use cases of threads.default_role separately in this file:
- Attempts to fetch the role permissions for the default role in the thread (expected return result size is one row)
- Ran the query before and after in my MariaDB on my local database and saw the same results printed out
- Fetches the user, role and default_role from memberships to determine whether the user is a 'default role user'
- Ran the query before and after in my MariaDB on my local database and saw the same results printed out
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
keyserver/src/updaters/thread-updaters.js | ||
---|---|---|
211 ↗ | (On Diff #33603) | Makes me wonder if we should update the thread index on roles to be a thread, special_role index |
keyserver/src/updaters/thread-updaters.js | ||
---|---|---|
211 ↗ | (On Diff #33603) | Makes sense, but shouldn't matter too much, as we probably don't expect more than a couple of roles per thread |