Page MenuHomePhabricator

[keyserver] Update usage of threads.default_role in thread-fetchers.js
ClosedPublic

Authored by rohan on Nov 24 2023, 9:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 15, 3:09 AM
Unknown Object (File)
Apr 19 2024, 12:32 AM
Unknown Object (File)
Apr 8 2024, 10:35 PM
Unknown Object (File)
Apr 8 2024, 10:35 PM
Unknown Object (File)
Apr 8 2024, 10:34 PM
Unknown Object (File)
Apr 4 2024, 2:27 AM
Unknown Object (File)
Feb 21 2024, 10:41 AM
Unknown Object (File)
Feb 21 2024, 5:58 AM
Subscribers

Details

Summary

We need to get rid of usages of threads.default_role throughout the codebase so we can eventually drop the column.

This diff handles the usage in thread-fetchers.js

Existing code: Fetches the default_role when constructed threadInfos to set the isDefault flag for each role in threadInfo.roles

Depends on D9979

Addresses part of ENG-5833

Test Plan

Updated my query and logged the threadInfo.roles. Confirmed that for each role, isDefault was set to true for all Members and false otherwise.

Another test I did was to compare the logged threadInfo.roles both before and after the query change and they were identical

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable