Differential D10056

Rename IOS to APNs in function responsible for notifications encryption
ClosedPublic
Actions

Authored by marcin on Nov 27 2023, 6:44 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Mar 27, 1:25 PM

	Unknown Object (File)
	Fri, Mar 14, 2:04 PM

	Unknown Object (File)
	Thu, Mar 13, 5:57 AM

	Unknown Object (File)
	Thu, Mar 13, 5:57 AM

	Unknown Object (File)
	Thu, Mar 13, 5:57 AM

	Unknown Object (File)
	Thu, Mar 13, 5:57 AM

	Unknown Object (File)
	Thu, Mar 13, 5:57 AM

	Unknown Object (File)
	Thu, Mar 13, 5:57 AM

Subscribers

Details

Reviewers

Commits

rCOMM7a5fb8d380a2: Rename IOS to APNs in function responsible for notifications encryption

Summary

This differential renames functions responsible for notification encryption to use "APNs" instead of "IOS" to emphasize that notifications encryption will
cover all Apple devices.

Test Plan

Ensure that flow and eslint do not complain.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

marcin created this revision.Nov 27 2023, 6:44 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 27 2023, 6:44 AM

marcin added a parent revision: D9973: Expose major version of desktop code to the keyserver.Nov 27 2023, 6:45 AM

marcin added a child revision: D10057: Encrypt notifications for MacOS clients with code versions supporting notification decryption.Nov 27 2023, 6:56 AM

Harbormaster completed remote builds in B24523: Diff 33729.Nov 27 2023, 10:01 AM

marcin requested review of this revision.Nov 27 2023, 10:01 AM

michal accepted this revision.Nov 28 2023, 2:19 AM

This revision is now accepted and ready to land.Nov 28 2023, 2:19 AM

Rebase

Harbormaster completed remote builds in B24558: Diff 33933.Nov 28 2023, 6:23 AM

Rebase before landing

Rebase before landing

Rebase before landing

Harbormaster completed remote builds in B24627: Diff 34032.Nov 30 2023, 3:43 AM

Harbormaster completed remote builds in B24630: Diff 34035.Nov 30 2023, 4:19 AM

Harbormaster completed remote builds in B24635: Diff 34040.Nov 30 2023, 5:18 AM

Closed by commit rCOMM7a5fb8d380a2: Rename IOS to APNs in function responsible for notifications encryption (authored by marcin). · Explain WhyNov 30 2023, 5:37 AM

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM7a5fb8d380a2: Rename IOS to APNs in function responsible for notifications encryption.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

10 lines

8 lines

Diff 34040

keyserver/src/push/crypto.js

	Show First 20 Lines • Show All 97 Lines • ▼ Show 20 Lines		"dependencies": {
	"react-native-progress": "^4.1.2",			"react-native-progress": "^4.1.2",
	"react-native-reanimated": "^2.10.0",			"react-native-reanimated": "^2.10.0",
	"react-native-safe-area-context": "^3.1.9",			"react-native-safe-area-context": "^3.1.9",
	"react-native-safe-area-view": "^2.0.0",			"react-native-safe-area-view": "^2.0.0",
	"react-native-screens": "~3.8.0",			"react-native-screens": "~3.8.0",
	"react-native-svg": "^12.3.0",			"react-native-svg": "^12.3.0",
	"react-native-tab-view": "^3.3.0",			"react-native-tab-view": "^3.3.0",
	"react-native-vector-icons": "^6.6.0",			"react-native-vector-icons": "^6.6.0",
	"react-native-video": "~5.1.1",			"react-native-video": "^5.2.1",
	"react-native-webview": "^11.23.0",			"react-native-webview": "^11.23.0",
	"react-redux": "^7.1.1",			"react-redux": "^7.1.1",
	"reactotron-react-native": "^5.0.3",			"reactotron-react-native": "^5.0.3",
	"reactotron-redux": "^3.1.3",			"reactotron-redux": "^3.1.3",
	"redux": "^4.0.4",			"redux": "^4.0.4",
	"redux-persist": "^6.0.0",			"redux-persist": "^6.0.0",
	"redux-thunk": "^2.2.0",			"redux-thunk": "^2.2.0",
	"reselect": "^4.0.0",			"reselect": "^4.0.0",
	"shallowequal": "^1.0.2",			"shallowequal": "^1.0.2",
	"simple-markdown": "^0.7.2",			"simple-markdown": "^0.7.2",
	"tinycolor2": "^1.4.1"			"tinycolor2": "^1.4.1"
	},			},
	"jest": {			"jest": {
	"preset": "react-native"			"preset": "react-native"
	}			}
	}			}

keyserver/src/push/send.js

	Show First 20 Lines • Show All 97 Lines • ▼ Show 20 Lines		"dependencies": {
	"react-native-progress": "^4.1.2",			"react-native-progress": "^4.1.2",
	"react-native-reanimated": "^2.10.0",			"react-native-reanimated": "^2.10.0",
	"react-native-safe-area-context": "^3.1.9",			"react-native-safe-area-context": "^3.1.9",
	"react-native-safe-area-view": "^2.0.0",			"react-native-safe-area-view": "^2.0.0",
	"react-native-screens": "~3.8.0",			"react-native-screens": "~3.8.0",
	"react-native-svg": "^12.3.0",			"react-native-svg": "^12.3.0",
	"react-native-tab-view": "^3.3.0",			"react-native-tab-view": "^3.3.0",
	"react-native-vector-icons": "^6.6.0",			"react-native-vector-icons": "^6.6.0",
	"react-native-video": "~5.1.1",			"react-native-video": "^5.2.1",
	"react-native-webview": "^11.23.0",			"react-native-webview": "^11.23.0",
	"react-redux": "^7.1.1",			"react-redux": "^7.1.1",
	"reactotron-react-native": "^5.0.3",			"reactotron-react-native": "^5.0.3",
	"reactotron-redux": "^3.1.3",			"reactotron-redux": "^3.1.3",
	"redux": "^4.0.4",			"redux": "^4.0.4",
	"redux-persist": "^6.0.0",			"redux-persist": "^6.0.0",
	"redux-thunk": "^2.2.0",			"redux-thunk": "^2.2.0",
	"reselect": "^4.0.0",			"reselect": "^4.0.0",
	"shallowequal": "^1.0.2",			"shallowequal": "^1.0.2",
	"simple-markdown": "^0.7.2",			"simple-markdown": "^0.7.2",
	"tinycolor2": "^1.4.1"			"tinycolor2": "^1.4.1"
	},			},
	"jest": {			"jest": {
	"preset": "react-native"			"preset": "react-native"
	}			}
	}			}