Page MenuHomePhabricator

[lib][web][native] Refactor invalidSessionDowngrade for setNewSessionActionType
ClosedPublic

Authored by inka on Nov 30 2023, 5:31 AM.
Tags
None
Referenced Files
F3367784: D10096.id34042.diff
Mon, Nov 25, 4:23 PM
Unknown Object (File)
Fri, Nov 8, 5:54 PM
Unknown Object (File)
Fri, Nov 1, 2:00 AM
Unknown Object (File)
Wed, Oct 30, 11:24 PM
Unknown Object (File)
Oct 2 2024, 4:13 AM
Unknown Object (File)
Oct 2 2024, 4:13 AM
Unknown Object (File)
Oct 2 2024, 4:13 AM
Unknown Object (File)
Oct 2 2024, 4:12 AM
Subscribers

Details

Summary

issue: https://linear.app/comm/issue/ENG-5888/refactor-invalidsessiondowngrade
We know the id of the keyserver setNewSessionActionType was called for, we should use it instead of the hardcoded ashoatKeyserverID
I will update the logic for logOutActionTypes and deleteAccountActionTypes in next diffs

Test Plan

Tested that the setNewSessionActionType still works - changes the state if invalidSessionDowngrade returns false. Checked that if a cookie or sessionId are changed invalidSessionDowngrade still returns true

Diff Detail

Repository
rCOMM Comm
Branch
inka/invalidSessionDowngrade
Lint
No Lint Coverage
Unit
No Test Coverage