Page MenuHomePhabricator
Differential D10141

[web] introduce light mode to roles modal
ClosedPublic
Actions

Authored by ginsu on Dec 1 2023, 11:16 AM.
Tags
None
Referenced Files
F3364700: D10141.diff
Mon, Nov 25, 4:43 AM
Unknown Object (File)
Wed, Nov 13, 7:32 AM
Unknown Object (File)
Wed, Nov 13, 7:32 AM
Unknown Object (File)
Wed, Nov 13, 7:32 AM
Unknown Object (File)
Wed, Nov 13, 7:31 AM
Unknown Object (File)
Wed, Nov 13, 7:31 AM
Unknown Object (File)
Oct 23 2024, 3:36 AM
Unknown Object (File)
Oct 11 2024, 11:51 PM
View All 66 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
rohan
Commits
rCOMM7f461010fa90: [web] introduce light mode to roles modal
Summary

This diff introduces the new color design system/light mode to the roles modal

For additional context about this new color design system and the new naming convention here is the notion doc:
https://www.notion.so/commapp/New-Color-System-Proposal-ef80b4e4b9ec42949095056161223a42

linear task: https://linear.app/comm/issue/ENG-4839/roles-modal

Test Plan

Please see the screenshots below

dark:

Screenshot 2023-12-01 at 2.17.56 PM.png (1×3 px, 761 KB)

light:

Screenshot 2023-12-01 at 2.18.09 PM.png (1×3 px, 756 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 1 2023, 11:16 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 1 2023, 11:16 AM
ginsu edited the summary of this revision. (Show Details)Dec 1 2023, 11:18 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, rohan.
ginsu attached a referenced file: F905930: Screenshot 2023-12-01 at 2.18.09 PM.png. (Show Details)
ginsu attached a referenced file: F905929: Screenshot 2023-12-01 at 2.17.56 PM.png. (Show Details)
ginsu added inline comments.
web/theme.css
233 ↗(On Diff #34133)

Confirmed that this is safe to remove

Harbormaster completed remote builds in B24701: Diff 34133.Dec 1 2023, 11:40 AM
ginsu requested review of this revision.Dec 1 2023, 11:40 AM
rohan accepted this revision.Dec 1 2023, 11:52 AM
This revision is now accepted and ready to land.Dec 1 2023, 11:52 AM
ginsu updated this revision to Diff 34168.Dec 4 2023, 12:25 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 4 2023, 12:32 AM
Closed by commit rCOMM7f461010fa90: [web] introduce light mode to roles modal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM7f461010fa90: [web] introduce light mode to roles modal.
Harbormaster completed remote builds in B24720: Diff 34168.Dec 4 2023, 12:43 AM

Revision Contents
Changeset List

Diff 34168

View Options

web/roles/community-roles-modal.css

Loading...
View Options

web/roles/role-actions-menu.css

Loading...
View Options

web/roles/role-panel-entry.css

Loading...
View Options

web/theme.css

Loading...