[keyserver] Fix error when changing thread description
ClosedPublic
Actions

Authored by inka on Dec 5 2023, 2:28 AM.

Details

Reviewers

marcin
ashoat
tomek

Commits

rCOMM608cc2e82423: [keyserver] Fix error when changing thread description

Summary

issue: https://linear.app/comm/issue/ENG-6013/unable-to-update-chat-description
In D9859 sqlUpdate.description = description ?? null; was changed to sqlUpdate.description;. This is probably a mistake, and should be sqlUpdate.description = description;. After this change it is possible to change the chats description again.

Test Plan

Tested that changing chat description works

Diff Detail

Repository

rCOMM Comm

Branch

inka/fix_change_thread_description

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

inka created this revision.Dec 5 2023, 2:28 AM

Adding @ashoat as blocking since this was his diff

Harbormaster completed remote builds in B24794: Diff 34265.Dec 5 2023, 2:46 AM

inka requested review of this revision.Dec 5 2023, 2:46 AM

tomek accepted this revision.Dec 5 2023, 5:20 AM

ashoat accepted this revision.Dec 5 2023, 5:39 AM

This revision is now accepted and ready to land.Dec 5 2023, 5:39 AM

Thanks for this fix, @inka!

Closed by commit rCOMM608cc2e82423: [keyserver] Fix error when changing thread description (authored by inka). · Explain WhyDec 5 2023, 6:20 AM

This revision was automatically updated to reflect the committed changes.

inka added a commit: rCOMM608cc2e82423: [keyserver] Fix error when changing thread description.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

updaters/

thread-updaters.js

2 lines

Diff 34265

View Options

keyserver/src/updaters/thread-updaters.js

	Show First 20 Lines • Show All 43 Lines • ▼ Show 20 Lines
	-DSQLITE_ENABLE_FTS3_PARENTHESIS			-DSQLITE_ENABLE_FTS3_PARENTHESIS
	-DSQLITE_THREADSAFE=0			-DSQLITE_THREADSAFE=0
	-DSQLITE_ENABLE_NORMALIZE			-DSQLITE_ENABLE_NORMALIZE
	-DSQLITE_HAS_CODEC			-DSQLITE_HAS_CODEC
	-DSQLITE_TEMP_STORE=2			-DSQLITE_TEMP_STORE=2
	-DSQLCIPHER_CRYPTO_OPENSSL			-DSQLCIPHER_CRYPTO_OPENSSL
	-DSQLITE_ENABLE_SESSION			-DSQLITE_ENABLE_SESSION
	-DSQLITE_ENABLE_PREUPDATE_HOOK			-DSQLITE_ENABLE_PREUPDATE_HOOK
				-DSQLITE_ENABLE_FTS5
	)			)

	download_openssl() {			download_openssl() {
	mkdir -p "$SQLITE_DIR"			mkdir -p "$SQLITE_DIR"

	curl "${OPENSSL_URL}" --output "${OPENSSL_FILE}"			curl "${OPENSSL_URL}" --output "${OPENSSL_FILE}"

	tar -xf "${OPENSSL_FILE}" -C "${SQLITE_DIR}"			tar -xf "${OPENSSL_FILE}" -C "${SQLITE_DIR}"
	▲ Show 20 Lines • Show All 112 Lines • Show Last 20 Lines

[keyserver] Fix error when changing thread descriptionClosedPublicActions