Page MenuHomePhabricator

[keyserver] Fix error when changing thread description
ClosedPublic

Authored by inka on Dec 5 2023, 2:28 AM.
Tags
None
Referenced Files
F3530982: D10189.id34278.diff
Wed, Dec 25, 5:30 AM
F3530978: D10189.id34265.diff
Wed, Dec 25, 5:30 AM
F3530977: D10189.id.diff
Wed, Dec 25, 5:30 AM
F3530976: D10189.diff
Wed, Dec 25, 5:30 AM
Unknown Object (File)
Nov 22 2024, 6:54 PM
Unknown Object (File)
Nov 22 2024, 5:34 PM
Unknown Object (File)
Nov 22 2024, 1:15 PM
Unknown Object (File)
Nov 18 2024, 2:51 AM
Subscribers
None

Details

Summary

issue: https://linear.app/comm/issue/ENG-6013/unable-to-update-chat-description
In D9859 sqlUpdate.description = description ?? null; was changed to sqlUpdate.description;. This is probably a mistake, and should be sqlUpdate.description = description;. After this change it is possible to change the chats description again.

Test Plan

Tested that changing chat description works

Diff Detail

Repository
rCOMM Comm
Branch
inka/fix_change_thread_description
Lint
No Lint Coverage
Unit
No Test Coverage