[web] make database errors more descriptive
ClosedPublic
Actions

Authored by kamil on Dec 5 2023, 3:38 AM.

Details

Reviewers

tomek
michal

Commits

rCOMM4a5aecdcada5: [web] make database errors more descriptive

Summary

This is improvement to: ENG-5910.

Test Plan

Cause error and check if it's logged with details.

Diff Detail

Repository

rCOMM Comm

Branch

improve-logging

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 5 2023, 3:38 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptDec 5 2023, 3:38 AM

Harbormaster completed remote builds in B24797: Diff 34270.Dec 5 2023, 4:03 AM

kamil published this revision for review.Dec 5 2023, 5:25 AM

tomek accepted this revision.Dec 5 2023, 5:54 AM

This revision is now accepted and ready to land.Dec 5 2023, 5:54 AM

Closed by commit rCOMM4a5aecdcada5: [web] make database errors more descriptive (authored by kamil). · Explain WhyDec 5 2023, 6:01 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM4a5aecdcada5: [web] make database errors more descriptive.

Revision Contents
Changeset List

Path

Size

web/

database/

worker/

db-worker.js

12 lines

Diff 34270

View Options

web/database/worker/db-worker.js

Show All 20 Lines	async getAllInboundP2PMessages(): Promise<InboundP2PMessage[]> {
const data = await sharedWorker.schedule({		const data = await sharedWorker.schedule({
type: workerRequestMessageTypes.GET_INBOUND_P2P_MESSAGES,		type: workerRequestMessageTypes.GET_INBOUND_P2P_MESSAGES,
});		});
const messages: ?$ReadOnlyArray<InboundP2PMessage> =		const messages: ?$ReadOnlyArray<InboundP2PMessage> =
data?.inboundP2PMessages;		data?.inboundP2PMessages;
return messages ? [...messages] : [];		return messages ? [...messages] : [];
},		},

		async getInboundP2PMessagesByID(
		ids: $ReadOnlyArray<string>,
		): Promise<Array<InboundP2PMessage>> {
		const sharedWorker = await getCommSharedWorker();

		const data = await sharedWorker.schedule({
		type: workerRequestMessageTypes.GET_INBOUND_P2P_MESSAGES_BY_ID,
		messageIDs: ids,
		});
		const messages: ?$ReadOnlyArray<InboundP2PMessage> =
		data?.inboundP2PMessages;
		return messages ? [...messages] : [];
		},

async getAllOutboundP2PMessages(): Promise<OutboundP2PMessage[]> {		async getAllOutboundP2PMessages(): Promise<OutboundP2PMessage[]> {
const sharedWorker = await getCommSharedWorker();		const sharedWorker = await getCommSharedWorker();

const data = await sharedWorker.schedule({		const data = await sharedWorker.schedule({
type: workerRequestMessageTypes.GET_OUTBOUND_P2P_MESSAGES,		type: workerRequestMessageTypes.GET_OUTBOUND_P2P_MESSAGES,
});		});
const messages: ?$ReadOnlyArray<OutboundP2PMessage> =		const messages: ?$ReadOnlyArray<OutboundP2PMessage> =
data?.outboundP2PMessages;		data?.outboundP2PMessages;
▲ Show 20 Lines • Show All 151 Lines • Show Last 20 Lines

[web] make database errors more descriptiveClosedPublicActions