Differential D10366

[services] update `Cargo.lock` files
ClosedPublic
Actions

Authored by kamil on Dec 18 2023, 3:54 AM.

Tags

None

Referenced Files

	F3376687: D10366.diff
	Wed, Nov 27, 1:38 AM

	Unknown Object (File)
	Sun, Nov 17, 8:54 AM

	Unknown Object (File)
	Sat, Nov 16, 10:48 AM

	Unknown Object (File)
	Wed, Nov 6, 8:14 PM

	Unknown Object (File)
	Oct 18 2024, 2:24 AM

	Unknown Object (File)
	Oct 18 2024, 2:24 AM

	Unknown Object (File)
	Oct 18 2024, 2:24 AM

	Unknown Object (File)
	Oct 18 2024, 2:24 AM

View All 59 Files

Subscribers

Details

Reviewers

varun
michal
bartek

Commits

rCOMM557352d79909: [services] update `Cargo.lock` files

Summary

D10343 changed dependencies in Rust

Test Plan

N/A

Diff Detail

Repository

Branch

land-locks

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Dec 18 2023, 3:54 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 18 2023, 3:54 AM

kamil published this revision for review.Dec 18 2023, 4:01 AM

Harbormaster completed remote builds in B25163: Diff 34778.Dec 18 2023, 4:12 AM

michal accepted this revision.Dec 18 2023, 5:07 AM

This revision is now accepted and ready to land.Dec 18 2023, 5:07 AM

add missing services

This revision was landed with ongoing or failed builds.Dec 18 2023, 7:00 AM

Closed by commit rCOMM557352d79909: [services] update `Cargo.lock` files (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM557352d79909: [services] update `Cargo.lock` files.

Harbormaster completed remote builds in B25184: Diff 34799.Dec 18 2023, 8:00 AM

kamil mentioned this in D10574: [services] update Cargo.lock files.Jan 8 2024, 2:43 AM

kamil mentioned this in rCOMMa89e9e112496: [services] update Cargo.lock files.Jan 8 2024, 3:25 AM

Do we know which diff this was caused by? (Ie. which diff didn't include corresponding lockfile updates that resulted from its changes)

In D10366#305651, @ashoat wrote:

Do we know which diff this was caused by? (Ie. which diff didn't include corresponding lockfile updates that resulted from its changes)

I guess it could be D10443? (cc. @bartek)

In D10366#305673, @kamil wrote:

I guess it could be D10443? (cc. @bartek)

I don't think so - the diff contents don't seem to be related (D10443 didn't touch any webpki-roots stuff).
Either way, having cargo workspaces would resolve such issues. Or another CI job 🙄 that does cargo build everywhere and compares lockfiles

kamil mentioned this in D10915: [services] update `Cargo.lock` in commtest.Feb 1 2024, 11:53 AM

kamil mentioned this in rCOMMe864a2978dd6: [services] update `Cargo.lock` in commtest.Feb 1 2024, 12:14 PM

Revision Contents
Changeset List

Path

Size

services/

backup/

blob/

comm-services-lib/

commtest/

feature-flags/

reports/

tunnelbroker/

Diff 34799

services/backup/Cargo.lock

Loading...

services/blob/Cargo.lock

Loading...

services/comm-services-lib/Cargo.lock

Loading...

services/commtest/Cargo.lock

Loading...

services/feature-flags/Cargo.lock

Loading...

services/reports/Cargo.lock

Loading...

services/tunnelbroker/Cargo.lock

Loading...