Page MenuHomePhabricator

[lib][web][native] Check if keyserver is present in store when adding it, unmark temporary
AbandonedPublic

Authored by inka on Jan 2 2024, 7:16 AM.
Tags
None
Referenced Files
F3373719: D10505.diff
Tue, Nov 26, 11:13 AM
Unknown Object (File)
Thu, Oct 31, 12:51 AM
Unknown Object (File)
Oct 16 2024, 2:09 AM
Unknown Object (File)
Oct 16 2024, 2:09 AM
Unknown Object (File)
Oct 16 2024, 2:09 AM
Unknown Object (File)
Sep 11 2024, 1:21 PM
Unknown Object (File)
Sep 11 2024, 1:21 PM
Unknown Object (File)
Sep 11 2024, 1:21 PM
Subscribers

Details

Reviewers
michal
kamil
ginsu
Summary

issue: ENG-6097
We need to remove the temporary flag when a keyserver is being intentionally added
It is possible that the keyserver is already present in the store. So we are only passing the values that we actually want to set, and using the default values or the values from the keyserver store for other fields

Test Plan

Tested that adding a keyserver still works and doesn't throw errors (tested on web). When we are adding a new keyserver it is already present in the store during addKeyserverActionType, because it was added by setNewSessionActionType during call to version endpoint

Diff Detail

Repository
rCOMM Comm
Branch
inka/set_new_session
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

inka requested review of this revision.Jan 2 2024, 7:39 AM

See comment here – I'm beginning to wonder if we should just abandon this stack in favor of simply ignoring "anonymous" cookies. They don't have any benefit and seem to result in a lot of unnecessary complexity

This stack is being abandoned in favour of D10506