Adding userID to reserved_usernames table. This is to enable future work streaming usernames to opensearch instance.
Depends on D10438
Details
Details
Test on local dev. Registered new user on ios and successfully persisted userID attribute in dynamoDB.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| services/identity/src/database.rs | ||
|---|---|---|
| 866–880 | i don't think we need to change this function at all. there's no reason to pass in the entire UserDetail since we're only using the username field | |
| services/identity/src/database.rs | ||
|---|---|---|
| 866–880 | So I'm using the return details right afterwards in client_services.rs. I changed it to take in User Details instead of usernames as to avoid additional code later filtering the full list of user_details with whether or not they had a username in filtered_user_usernames and just passing filtered_user_details directly. Do you think I should go ahead with changing the function back and just filtering the user details out of filtered_out_usernames? | |
| services/identity/src/database.rs | ||
|---|---|---|
| 866–880 | ah i see. i think it's fine as is, actually | |