Page MenuHomePhabricator
Differential D10480

[identity] [lib] [keyserver] [7/n] Add userID to reserved_usernames table in DDB
ClosedPublic
Actions

Authored by will on Dec 28 2023, 9:04 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 8:22 AM
Unknown Object (File)
Wed, Mar 19, 11:54 AM
Unknown Object (File)
Mon, Mar 17, 6:29 AM
Unknown Object (File)
Mon, Mar 17, 6:29 AM
Unknown Object (File)
Mon, Mar 17, 6:29 AM
Unknown Object (File)
Mon, Mar 17, 6:29 AM
Unknown Object (File)
Sun, Mar 16, 12:06 AM
Unknown Object (File)
Wed, Mar 12, 10:05 AM
View All 100 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMM1fbd675cb32f: [identity] [lib] [keyserver] [7/n] Add userID to reserved_usernames table in DDB
Summary

Adding userID to reserved_usernames table. This is to enable future work streaming usernames to opensearch instance.

Depends on D10438

Test Plan

Test on local dev. Registered new user on ios and successfully persisted userID attribute in dynamoDB.

Diff Detail

Repository
rCOMM Comm
Branch
identity-search
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Dec 28 2023, 9:04 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 28 2023, 9:04 AM
will published this revision for review.Dec 28 2023, 9:07 AM
Harbormaster failed remote builds in B25372: Diff 35051!Dec 28 2023, 9:17 AM
will planned changes to this revision.Jan 3 2024, 1:49 PM
will updated this revision to Diff 35179.Jan 3 2024, 5:17 PM

Rebase resolve build errors

Harbormaster completed remote builds in B25465: Diff 35179.Jan 3 2024, 5:41 PM
will added 1 blocking reviewer(s): varun.Jan 4 2024, 1:31 PM
varun requested changes to this revision.Jan 4 2024, 3:00 PM
varun added inline comments.
services/identity/src/database.rs
866–880 ↗(On Diff #35179)

i don't think we need to change this function at all. there's no reason to pass in the entire UserDetail since we're only using the username field

This revision now requires changes to proceed.Jan 4 2024, 3:00 PM
will added inline comments.Jan 4 2024, 3:41 PM
services/identity/src/database.rs
866–880 ↗(On Diff #35179)

So I'm using the return details right afterwards in client_services.rs.
add_usernames_to_reserved_usernames_table(filtered_user_details)

I changed it to take in User Details instead of usernames as to avoid additional code later filtering the full list of user_details with whether or not they had a username in filtered_user_usernames and just passing filtered_user_details directly.

Do you think I should go ahead with changing the function back and just filtering the user details out of filtered_out_usernames?

varun added inline comments.Jan 4 2024, 4:39 PM
services/identity/src/database.rs
866–880 ↗(On Diff #35179)

ah i see. i think it's fine as is, actually

varun accepted this revision.Jan 4 2024, 4:39 PM
This revision is now accepted and ready to land.Jan 4 2024, 4:39 PM
Closed by commit rCOMM1fbd675cb32f: [identity] [lib] [keyserver] [7/n] Add userID to reserved_usernames table in DDB (authored by will). · Explain WhyJan 16 2024, 4:08 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM1fbd675cb32f: [identity] [lib] [keyserver] [7/n] Add userID to reserved_usernames table in DDB.

Revision Contents
Changeset List

PathSize
keyserver/
src/
creators/
11 lines
cron/
8 lines
fetchers/
12 lines
lib/
types/
12 lines
services/
identity/
src/
8 lines
1 line
31 lines
12 lines

Diff 35051

View Options

keyserver/src/creators/account-creator.js

  • This file was added.
#import "CommServicesAuthMetadataEmitter.h"
#import <Foundation/Foundation.h>
#import <React/RCTBridgeModule.h>
#import <React/RCTEventEmitter.h>
NSString *const commServicesAuthMetadata = @"commServicesAuthMetadata";
@interface CommServicesAuthMetadataEmitterIOSWrapper
: RCTEventEmitter <RCTBridgeModule>
@property(nonatomic) BOOL hasListeners;
+ (void)sendAccessTokenToJS:(NSString *)accessToken
withUserID:(NSString *)userID;
@end
@implementation CommServicesAuthMetadataEmitterIOSWrapper
RCT_EXPORT_MODULE(CommServicesAuthMetadataEmitter);
static CommServicesAuthMetadataEmitterIOSWrapper *sharedInstance = nil;
- (instancetype)init {
self = [super init];
if (!self) {
return self;
}
_hasListeners = NO;
return self;
}
- (void)startObserving {
@synchronized([self class]) {
_hasListeners = YES;
sharedInstance = self;
}
}
- (void)stopObserving {
@synchronized([self class]) {
_hasListeners = NO;
sharedInstance = nil;
}
}
- (NSArray<NSString *> *)supportedEvents {
return @[ commServicesAuthMetadata ];
}
- (NSDictionary *)constantsToExport {
return @{@"COMM_SERVICES_AUTH_METADATA" : commServicesAuthMetadata};
}
+ (BOOL)requiresMainQueueSetup {
return YES;
}
+ (void)sendAccessTokenToJS:(NSString *)accessToken
withUserID:(NSString *)userID {
@synchronized([self class]) {
if (!sharedInstance) {
return;
}
// Event body must match UserLoginResponse
// type from 'lib/types/identity-service-types.js'
NSDictionary *eventBody =
@{@"accessToken" : accessToken, @"userID" : userID};
[sharedInstance sendEventWithName:commServicesAuthMetadata body:eventBody];
}
}
@end
namespace comm {
void CommServicesAuthMetadataEmitter::sendAuthMetadataToJS(
rust::String accessToken,
rust::String userID) {
NSString *accessTokenObjC =
[NSString stringWithCString:std::string(accessToken).c_str()
encoding:NSUTF8StringEncoding];
NSString *userIDObjC = [NSString stringWithCString:std::string(userID).c_str()
encoding:NSUTF8StringEncoding];
[CommServicesAuthMetadataEmitterIOSWrapper sendAccessTokenToJS:accessTokenObjC
withUserID:userIDObjC];
}
} // namespace comm
View Options

keyserver/src/cron/update-identity-reserved-usernames.js

  • This file was added.
#import "CommServicesAuthMetadataEmitter.h"
#import <Foundation/Foundation.h>
#import <React/RCTBridgeModule.h>
#import <React/RCTEventEmitter.h>
NSString *const commServicesAuthMetadata = @"commServicesAuthMetadata";
@interface CommServicesAuthMetadataEmitterIOSWrapper
: RCTEventEmitter <RCTBridgeModule>
@property(nonatomic) BOOL hasListeners;
+ (void)sendAccessTokenToJS:(NSString *)accessToken
withUserID:(NSString *)userID;
@end
@implementation CommServicesAuthMetadataEmitterIOSWrapper
RCT_EXPORT_MODULE(CommServicesAuthMetadataEmitter);
static CommServicesAuthMetadataEmitterIOSWrapper *sharedInstance = nil;
- (instancetype)init {
self = [super init];
if (!self) {
return self;
}
_hasListeners = NO;
return self;
}
- (void)startObserving {
@synchronized([self class]) {
_hasListeners = YES;
sharedInstance = self;
}
}
- (void)stopObserving {
@synchronized([self class]) {
_hasListeners = NO;
sharedInstance = nil;
}
}
- (NSArray<NSString *> *)supportedEvents {
return @[ commServicesAuthMetadata ];
}
- (NSDictionary *)constantsToExport {
return @{@"COMM_SERVICES_AUTH_METADATA" : commServicesAuthMetadata};
}
+ (BOOL)requiresMainQueueSetup {
return YES;
}
+ (void)sendAccessTokenToJS:(NSString *)accessToken
withUserID:(NSString *)userID {
@synchronized([self class]) {
if (!sharedInstance) {
return;
}
// Event body must match UserLoginResponse
// type from 'lib/types/identity-service-types.js'
NSDictionary *eventBody =
@{@"accessToken" : accessToken, @"userID" : userID};
[sharedInstance sendEventWithName:commServicesAuthMetadata body:eventBody];
}
}
@end
namespace comm {
void CommServicesAuthMetadataEmitter::sendAuthMetadataToJS(
rust::String accessToken,
rust::String userID) {
NSString *accessTokenObjC =
[NSString stringWithCString:std::string(accessToken).c_str()
encoding:NSUTF8StringEncoding];
NSString *userIDObjC = [NSString stringWithCString:std::string(userID).c_str()
encoding:NSUTF8StringEncoding];
[CommServicesAuthMetadataEmitterIOSWrapper sendAccessTokenToJS:accessTokenObjC
withUserID:userIDObjC];
}
} // namespace comm
View Options

keyserver/src/fetchers/user-fetchers.js

  • This file was added.
#import "CommServicesAuthMetadataEmitter.h"
#import <Foundation/Foundation.h>
#import <React/RCTBridgeModule.h>
#import <React/RCTEventEmitter.h>
NSString *const commServicesAuthMetadata = @"commServicesAuthMetadata";
@interface CommServicesAuthMetadataEmitterIOSWrapper
: RCTEventEmitter <RCTBridgeModule>
@property(nonatomic) BOOL hasListeners;
+ (void)sendAccessTokenToJS:(NSString *)accessToken
withUserID:(NSString *)userID;
@end
@implementation CommServicesAuthMetadataEmitterIOSWrapper
RCT_EXPORT_MODULE(CommServicesAuthMetadataEmitter);
static CommServicesAuthMetadataEmitterIOSWrapper *sharedInstance = nil;
- (instancetype)init {
self = [super init];
if (!self) {
return self;
}
_hasListeners = NO;
return self;
}
- (void)startObserving {
@synchronized([self class]) {
_hasListeners = YES;
sharedInstance = self;
}
}
- (void)stopObserving {
@synchronized([self class]) {
_hasListeners = NO;
sharedInstance = nil;
}
}
- (NSArray<NSString *> *)supportedEvents {
return @[ commServicesAuthMetadata ];
}
- (NSDictionary *)constantsToExport {
return @{@"COMM_SERVICES_AUTH_METADATA" : commServicesAuthMetadata};
}
+ (BOOL)requiresMainQueueSetup {
return YES;
}
+ (void)sendAccessTokenToJS:(NSString *)accessToken
withUserID:(NSString *)userID {
@synchronized([self class]) {
if (!sharedInstance) {
return;
}
// Event body must match UserLoginResponse
// type from 'lib/types/identity-service-types.js'
NSDictionary *eventBody =
@{@"accessToken" : accessToken, @"userID" : userID};
[sharedInstance sendEventWithName:commServicesAuthMetadata body:eventBody];
}
}
@end
namespace comm {
void CommServicesAuthMetadataEmitter::sendAuthMetadataToJS(
rust::String accessToken,
rust::String userID) {
NSString *accessTokenObjC =
[NSString stringWithCString:std::string(accessToken).c_str()
encoding:NSUTF8StringEncoding];
NSString *userIDObjC = [NSString stringWithCString:std::string(userID).c_str()
encoding:NSUTF8StringEncoding];
[CommServicesAuthMetadataEmitterIOSWrapper sendAccessTokenToJS:accessTokenObjC
withUserID:userIDObjC];
}
} // namespace comm
View Options

lib/types/crypto-types.js

  • This file was added.
#import "CommServicesAuthMetadataEmitter.h"
#import <Foundation/Foundation.h>
#import <React/RCTBridgeModule.h>
#import <React/RCTEventEmitter.h>
NSString *const commServicesAuthMetadata = @"commServicesAuthMetadata";
@interface CommServicesAuthMetadataEmitterIOSWrapper
: RCTEventEmitter <RCTBridgeModule>
@property(nonatomic) BOOL hasListeners;
+ (void)sendAccessTokenToJS:(NSString *)accessToken
withUserID:(NSString *)userID;
@end
@implementation CommServicesAuthMetadataEmitterIOSWrapper
RCT_EXPORT_MODULE(CommServicesAuthMetadataEmitter);
static CommServicesAuthMetadataEmitterIOSWrapper *sharedInstance = nil;
- (instancetype)init {
self = [super init];
if (!self) {
return self;
}
_hasListeners = NO;
return self;
}
- (void)startObserving {
@synchronized([self class]) {
_hasListeners = YES;
sharedInstance = self;
}
}
- (void)stopObserving {
@synchronized([self class]) {
_hasListeners = NO;
sharedInstance = nil;
}
}
- (NSArray<NSString *> *)supportedEvents {
return @[ commServicesAuthMetadata ];
}
- (NSDictionary *)constantsToExport {
return @{@"COMM_SERVICES_AUTH_METADATA" : commServicesAuthMetadata};
}
+ (BOOL)requiresMainQueueSetup {
return YES;
}
+ (void)sendAccessTokenToJS:(NSString *)accessToken
withUserID:(NSString *)userID {
@synchronized([self class]) {
if (!sharedInstance) {
return;
}
// Event body must match UserLoginResponse
// type from 'lib/types/identity-service-types.js'
NSDictionary *eventBody =
@{@"accessToken" : accessToken, @"userID" : userID};
[sharedInstance sendEventWithName:commServicesAuthMetadata body:eventBody];
}
}
@end
namespace comm {
void CommServicesAuthMetadataEmitter::sendAuthMetadataToJS(
rust::String accessToken,
rust::String userID) {
NSString *accessTokenObjC =
[NSString stringWithCString:std::string(accessToken).c_str()
encoding:NSUTF8StringEncoding];
NSString *userIDObjC = [NSString stringWithCString:std::string(userID).c_str()
encoding:NSUTF8StringEncoding];
[CommServicesAuthMetadataEmitterIOSWrapper sendAccessTokenToJS:accessTokenObjC
withUserID:userIDObjC];
}
} // namespace comm
View Options

services/identity/src/client_service.rs

  • This file was added.
#import "CommServicesAuthMetadataEmitter.h"
#import <Foundation/Foundation.h>
#import <React/RCTBridgeModule.h>
#import <React/RCTEventEmitter.h>
NSString *const commServicesAuthMetadata = @"commServicesAuthMetadata";
@interface CommServicesAuthMetadataEmitterIOSWrapper
: RCTEventEmitter <RCTBridgeModule>
@property(nonatomic) BOOL hasListeners;
+ (void)sendAccessTokenToJS:(NSString *)accessToken
withUserID:(NSString *)userID;
@end
@implementation CommServicesAuthMetadataEmitterIOSWrapper
RCT_EXPORT_MODULE(CommServicesAuthMetadataEmitter);
static CommServicesAuthMetadataEmitterIOSWrapper *sharedInstance = nil;
- (instancetype)init {
self = [super init];
if (!self) {
return self;
}
_hasListeners = NO;
return self;
}
- (void)startObserving {
@synchronized([self class]) {
_hasListeners = YES;
sharedInstance = self;
}
}
- (void)stopObserving {
@synchronized([self class]) {
_hasListeners = NO;
sharedInstance = nil;
}
}
- (NSArray<NSString *> *)supportedEvents {
return @[ commServicesAuthMetadata ];
}
- (NSDictionary *)constantsToExport {
return @{@"COMM_SERVICES_AUTH_METADATA" : commServicesAuthMetadata};
}
+ (BOOL)requiresMainQueueSetup {
return YES;
}
+ (void)sendAccessTokenToJS:(NSString *)accessToken
withUserID:(NSString *)userID {
@synchronized([self class]) {
if (!sharedInstance) {
return;
}
// Event body must match UserLoginResponse
// type from 'lib/types/identity-service-types.js'
NSDictionary *eventBody =
@{@"accessToken" : accessToken, @"userID" : userID};
[sharedInstance sendEventWithName:commServicesAuthMetadata body:eventBody];
}
}
@end
namespace comm {
void CommServicesAuthMetadataEmitter::sendAuthMetadataToJS(
rust::String accessToken,
rust::String userID) {
NSString *accessTokenObjC =
[NSString stringWithCString:std::string(accessToken).c_str()
encoding:NSUTF8StringEncoding];
NSString *userIDObjC = [NSString stringWithCString:std::string(userID).c_str()
encoding:NSUTF8StringEncoding];
[CommServicesAuthMetadataEmitterIOSWrapper sendAccessTokenToJS:accessTokenObjC
withUserID:userIDObjC];
}
} // namespace comm
View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/database.rs

Loading...
View Options

services/identity/src/reserved_users.rs

Loading...