Page MenuHomePhabricator
Differential D10549

[web] update the thread top bar ui
AcceptedPublic
Actions

Authored by ginsu on Jan 5 2024, 12:16 AM.
Tags
None
Referenced Files
F3373999: D10549.diff
Tue, Nov 26, 1:10 PM
Unknown Object (File)
Sat, Nov 23, 12:54 AM
Unknown Object (File)
Sat, Nov 23, 12:39 AM
Unknown Object (File)
Sat, Nov 23, 12:08 AM
Unknown Object (File)
Fri, Nov 22, 1:35 AM
Unknown Object (File)
Tue, Nov 12, 11:01 PM
Unknown Object (File)
Tue, Nov 12, 8:50 AM
Unknown Object (File)
Fri, Nov 8, 8:11 PM
View All 66 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Summary

PLEASE NOTE THAT THIS DIFF AND SUBSEQUENT DIFFS IN THIS STACK WILL NOT BE LANDED UNTIL MORE OF THE REDESIGN IS READY SINCE THIS WILL CAUSE REGRESSIONS IN PROD

This diff updates the thread top bar ui to match the ui of the new web app redesign. This component will be used as the panel header for the message list panel item. For context here is the figma screenshot for reference:

Screenshot 2024-01-05 at 3.23.35 AM.png (208×2 px, 47 KB)

Linear task: https://linear.app/comm/issue/ENG-5973/update-the-message-list-header-ui

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jan 5 2024, 12:16 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 5 2024, 12:16 AM
ginsu updated this revision to Diff 35263.Jan 5 2024, 12:18 AM

update

ginsu edited the summary of this revision. (Show Details)Jan 5 2024, 12:24 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu attached a referenced file: F1029866: Screenshot 2024-01-05 at 3.23.35 AM.png. (Show Details)
ginsu added inline comments.Jan 5 2024, 12:28 AM
web/theme.css
285

Not sure what the heck I was thinking/doing by creating two identical color variables. Anyways, I realized it while working on this diff so I snuck the fix here

Harbormaster failed remote builds in B25526: Diff 35262!Jan 5 2024, 12:29 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Jan 5 2024, 12:31 AM
Harbormaster failed remote builds in B25527: Diff 35263!
ginsu updated this revision to Diff 35264.Jan 5 2024, 12:36 AM
ginsu edited the summary of this revision. (Show Details)

update

Harbormaster completed remote builds in B25528: Diff 35264.Jan 5 2024, 12:54 AM
ginsu requested review of this revision.Jan 5 2024, 12:54 AM
ginsu added inline comments.Jan 5 2024, 10:52 AM
web/theme.css
285 ↗(On Diff #35264)

Not sure what the heck I was thinking/doing by creating two identical color variables. Anyways, I realized it while working on this diff so I snuck the fix here

ginsu mentioned this in D10562: [web] fix button tertiary colors.Jan 7 2024, 11:43 PM
ginsu updated this revision to Diff 35339.Jan 7 2024, 11:58 PM

rebase

ginsu added a child revision: D10564: [web] update chat thread composer ui.Jan 8 2024, 12:14 AM
Harbormaster failed remote builds in B25572: Diff 35339!Jan 8 2024, 12:28 AM
atul accepted this revision.Jan 9 2024, 11:23 PM
This revision is now accepted and ready to land.Jan 9 2024, 11:23 PM
ginsu mentioned this in rCOMM3a12b8fa709c: [web] fix button tertiary colors.Jan 11 2024, 10:33 AM

Revision Contents
Changeset List

PathSize
web/
chat/
6 lines
56 lines
community-header/
2 lines
4 lines

Diff 35263

View Options

web/chat/thread-top-bar.css

Loading...
View Options

web/chat/thread-top-bar.react.js

Loading...
View Options

web/community-header/community-header-button.css

Loading...
View Options

web/theme.css

Loading...