Update gRPC-web generated files
ClosedPublic
Actions

Authored by bartek on Jan 8 2024, 2:18 AM.

Details

Reviewers

ashoat
varun

Commits

rCOMM2028825c7ee2: Update gRPC-web generated files

Summary

Updated gRPC-web code generated files.

Notable changes:

Using snake_case in proto finally generated proper camelCase here 🎉
In D10429 I renamed pre_key -> prekey and PreKey -> Prekey - lots of changes here related to this
Left inline comments for other changes

Depends on D10430

Test Plan

yarn flow on web, similiar to D10064 (previous update).

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

bartek held this revision as a draft.

bartek edited the test plan for this revision. (Show Details)

Unrelated Android CI issue, I'll restart the job once resolved

web/protobufs/identity-auth-client.cjs.flow
83–90 ↗	(On Diff #35351)	Introduced in D10301 This comment applies to all other `GetDeviceList` types introduced below*
web/protobufs/identity-auth-structs.cjs.flow
266–278 ↗	(On Diff #35351)	This was my oversight in previous update - these methods should've been removed due to changes in D9930
322 ↗	(On Diff #35351)	Doesn't seem to be used anywhere but the TypeScript file had it implemented. I know this is generated for enums, but I'm not sure why `number`s have it too. @varun, do you have any clue?
web/protobufs/identity-unauth-structs.cjs.flow
447 ↗	(On Diff #35351)	Renamed in the first diff of this stack

Commit missing file

Seems correct

looks so much better!!

web/protobufs/identity-auth-structs.cjs.flow
322 ↗	(On Diff #35351)	no idea... seems fine to remove

This revision is now accepted and ready to land.Jan 8 2024, 7:21 AM

web/protobufs/identity-auth-structs.cjs.flow
322 ↗	(On Diff #35351)	Removing it might cause more pain than leaving it there... it's good to keep our Flow libdefs minimally different from the auto-generated TypeScript ones