Page MenuHomePhabricator
Differential D9930

[identity] Move UpdateUserPassword RPCs
ClosedPublic
Actions

Authored by bartek on Mon, Nov 20, 4:20 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 27, 3:59 AM
Unknown Object (File)
Tue, Nov 21, 2:23 AM
Unknown Object (File)
Tue, Nov 21, 2:06 AM
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMM717a10d3297b: [identity] Move UpdateUserPassword RPCs
Summary

Moved UpdateUserPassword RPC to the authenticated proto.

Depends on D9929

Test Plan

Registered with Identity Service, was able to log in. Hardcoded call to update_user_password() in native client and verified that password was updated by performning login again.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Mon, Nov 20, 4:20 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptMon, Nov 20, 4:20 AM
bartek added a child revision: D9931: [identity] Move Logout and DeleteUser RPCs.Mon, Nov 20, 4:23 AM
bartek published this revision for review.Mon, Nov 20, 4:51 AM
Harbormaster completed remote builds in B24270: Diff 33408.Mon, Nov 20, 5:01 AM
varun accepted this revision.Mon, Nov 20, 11:38 AM
This revision is now accepted and ready to land.Mon, Nov 20, 11:38 AM
varun requested changes to this revision.Mon, Nov 27, 10:25 AM

i forgot that we need to update the gRPC web codegen files. can you please do that?

This revision now requires changes to proceed.Mon, Nov 27, 10:25 AM
bartek requested review of this revision.Tue, Nov 28, 8:04 AM
In D9930#292405, @varun wrote:

i forgot that we need to update the gRPC web codegen files. can you please do that?

I created D10064 to update them all at once

varun accepted this revision.Wed, Nov 29, 6:09 AM
This revision is now accepted and ready to land.Wed, Nov 29, 6:09 AM
Closed by commit rCOMM717a10d3297b: [identity] Move UpdateUserPassword RPCs (authored by bartek). · Explain WhyMon, Dec 4, 2:43 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM717a10d3297b: [identity] Move UpdateUserPassword RPCs.

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
16 lines
services/
identity/
src/
80 lines
grpc_services/
74 lines
4 lines
shared/
protos/
30 lines
35 lines

Diff 34173

View Options

native/native_rust_library/src/lib.rs

Loading...
View Options

services/identity/src/client_service.rs

Loading...
View Options

services/identity/src/grpc_services/authenticated.rs

Loading...
View Options

services/identity/src/main.rs

Loading...
View Options

shared/protos/identity_authenticated.proto

Loading...
View Options

shared/protos/identity_client.proto

Loading...