Page MenuHomePhabricator
Differential D9930

[identity] Move UpdateUserPassword RPCs
ClosedPublic
Actions

Authored by bartek on Nov 20 2023, 4:20 AM.
Tags
None
Referenced Files
F5275660: D9930.diff
Mon, Apr 7, 6:03 AM
Unknown Object (File)
Mon, Mar 31, 10:02 PM
Unknown Object (File)
Mar 6 2025, 4:58 AM
Unknown Object (File)
Mar 5 2025, 3:01 PM
Unknown Object (File)
Mar 4 2025, 2:54 PM
Unknown Object (File)
Mar 4 2025, 2:02 PM
Unknown Object (File)
Feb 25 2025, 7:58 PM
Unknown Object (File)
Feb 20 2025, 11:39 PM
View All 99 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMM717a10d3297b: [identity] Move UpdateUserPassword RPCs
Summary

Moved UpdateUserPassword RPC to the authenticated proto.

Depends on D9929

Test Plan

Registered with Identity Service, was able to log in. Hardcoded call to update_user_password() in native client and verified that password was updated by performning login again.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Nov 20 2023, 4:20 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 20 2023, 4:20 AM
bartek added a child revision: D9931: [identity] Move Logout and DeleteUser RPCs.Nov 20 2023, 4:23 AM
bartek published this revision for review.Nov 20 2023, 4:51 AM
Harbormaster completed remote builds in B24270: Diff 33408.Nov 20 2023, 5:01 AM
varun accepted this revision.Nov 20 2023, 11:38 AM
This revision is now accepted and ready to land.Nov 20 2023, 11:38 AM
varun requested changes to this revision.Nov 27 2023, 10:25 AM

i forgot that we need to update the gRPC web codegen files. can you please do that?

This revision now requires changes to proceed.Nov 27 2023, 10:25 AM
bartek requested review of this revision.Nov 28 2023, 8:04 AM
In D9930#292405, @varun wrote:

i forgot that we need to update the gRPC web codegen files. can you please do that?

I created D10064 to update them all at once

varun accepted this revision.Nov 29 2023, 6:09 AM
This revision is now accepted and ready to land.Nov 29 2023, 6:09 AM
Closed by commit rCOMM717a10d3297b: [identity] Move UpdateUserPassword RPCs (authored by bartek). · Explain WhyDec 4 2023, 2:43 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM717a10d3297b: [identity] Move UpdateUserPassword RPCs.
bartek mentioned this in D10573: Update gRPC-web generated files.Jan 8 2024, 2:49 AM

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
16 lines
services/
identity/
src/
80 lines
grpc_services/
74 lines
4 lines
shared/
protos/
30 lines
35 lines

Diff 34173

View Options

native/native_rust_library/src/lib.rs

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines if (!hasNonce) {
return ( return (
<div className={css.wrapper}> <div className={css.wrapper}>
<div className={css.walletDisplay}> <div className={css.walletDisplay}>
<span className={css.walletDisplayText}>Wallet Connected:</span> <span className={css.walletDisplayText}>Wallet Connected:</span>
<ConnectButton /> <ConnectButton />
</div> </div>
<p>{siweMessageSigningExplanationStatements[0]}</p> <p>{siweMessageSigningExplanationStatements[0]}</p>
<p>{siweMessageSigningExplanationStatements[1]}</p> <p>{siweMessageSigningExplanationStatements[1]}</p>
<p>
By signing up, you agree to our{' '}
<a href="https://comm.app/terms">Terms of Use</a> &{' '}
<a href="https://comm.app/privacy">Privacy Policy</a>.
</p>
<div className={css.button} onClick={onClick}> <div className={css.button} onClick={onClick}>
Sign in Sign in
</div> </div>
</div> </div>
); );
} }
} }
Show All 22 Lines
View Options

services/identity/src/client_service.rs

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines if (!hasNonce) {
return ( return (
<div className={css.wrapper}> <div className={css.wrapper}>
<div className={css.walletDisplay}> <div className={css.walletDisplay}>
<span className={css.walletDisplayText}>Wallet Connected:</span> <span className={css.walletDisplayText}>Wallet Connected:</span>
<ConnectButton /> <ConnectButton />
</div> </div>
<p>{siweMessageSigningExplanationStatements[0]}</p> <p>{siweMessageSigningExplanationStatements[0]}</p>
<p>{siweMessageSigningExplanationStatements[1]}</p> <p>{siweMessageSigningExplanationStatements[1]}</p>
<p>
By signing up, you agree to our{' '}
<a href="https://comm.app/terms">Terms of Use</a> &{' '}
<a href="https://comm.app/privacy">Privacy Policy</a>.
</p>
<div className={css.button} onClick={onClick}> <div className={css.button} onClick={onClick}>
Sign in Sign in
</div> </div>
</div> </div>
); );
} }
} }
Show All 22 Lines
View Options

services/identity/src/grpc_services/authenticated.rs

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines if (!hasNonce) {
return ( return (
<div className={css.wrapper}> <div className={css.wrapper}>
<div className={css.walletDisplay}> <div className={css.walletDisplay}>
<span className={css.walletDisplayText}>Wallet Connected:</span> <span className={css.walletDisplayText}>Wallet Connected:</span>
<ConnectButton /> <ConnectButton />
</div> </div>
<p>{siweMessageSigningExplanationStatements[0]}</p> <p>{siweMessageSigningExplanationStatements[0]}</p>
<p>{siweMessageSigningExplanationStatements[1]}</p> <p>{siweMessageSigningExplanationStatements[1]}</p>
<p>
By signing up, you agree to our{' '}
<a href="https://comm.app/terms">Terms of Use</a> &{' '}
<a href="https://comm.app/privacy">Privacy Policy</a>.
</p>
<div className={css.button} onClick={onClick}> <div className={css.button} onClick={onClick}>
Sign in Sign in
</div> </div>
</div> </div>
); );
} }
} }
Show All 22 Lines
View Options

services/identity/src/main.rs

Show First 20 Lines • Show All 130 Lines • ▼ Show 20 Lines if (!hasNonce) {
return ( return (
<div className={css.wrapper}> <div className={css.wrapper}>
<div className={css.walletDisplay}> <div className={css.walletDisplay}>
<span className={css.walletDisplayText}>Wallet Connected:</span> <span className={css.walletDisplayText}>Wallet Connected:</span>
<ConnectButton /> <ConnectButton />
</div> </div>
<p>{siweMessageSigningExplanationStatements[0]}</p> <p>{siweMessageSigningExplanationStatements[0]}</p>
<p>{siweMessageSigningExplanationStatements[1]}</p> <p>{siweMessageSigningExplanationStatements[1]}</p>
<p>
By signing up, you agree to our{' '}
<a href="https://comm.app/terms">Terms of Use</a> &{' '}
<a href="https://comm.app/privacy">Privacy Policy</a>.
</p>
<div className={css.button} onClick={onClick}> <div className={css.button} onClick={onClick}>
Sign in Sign in
</div> </div>
</div> </div>
); );
} }
} }
Show All 22 Lines
View Options

shared/protos/identity_authenticated.proto

Loading...
View Options

shared/protos/identity_client.proto

Loading...