Paths

Table of Contentst

Differential D10051

[identity] Move X3DH message types to auth proto
ClosedPublic
Actions

Authored by bartek on Nov 27 2023, 4:26 AM.

Details

Reviewers

varun

Commits

rCOMMac49739d0cd7: [identity] Move X3DH message types to auth proto

Summary

Moved message types specific to GetOutboundKeys (these have been partially here already) and GetInboundKeys to the auth proto

Depends on D10050

Test Plan

Identity Service and clients still compile, I'm able to make successful RPC calls

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Nov 27 2023, 4:26 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 27 2023, 4:26 AM

bartek added a child revision: D10052: [identity] Move proto generated modules to one place.Nov 27 2023, 4:27 AM

bartek edited the summary of this revision. (Show Details)Nov 27 2023, 4:28 AM

bartek edited the test plan for this revision. (Show Details)

Harbormaster failed remote builds in B24496: Diff 33701!Nov 27 2023, 4:36 AM

Rebase

Harbormaster completed remote builds in B24517: Diff 33723.Nov 27 2023, 8:49 AM

bartek published this revision for review.Nov 28 2023, 8:05 AM

varun accepted this revision.Nov 29 2023, 6:23 AM

This revision is now accepted and ready to land.Nov 29 2023, 6:23 AM

Closed by commit rCOMMac49739d0cd7: [identity] Move X3DH message types to auth proto (authored by bartek). · Explain WhyDec 6 2023, 3:17 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMac49739d0cd7: [identity] Move X3DH message types to auth proto.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

src/

identity_client/

mod.rs

6 lines

native/

native_rust_library/

src/

lib.rs

4 lines

services/

identity/

src/

grpc_services/

authenticated.rs

25 lines

grpc_utils.rs

8 lines

shared/

protos/

identity_authenticated.proto

29 lines

identity_client.proto

29 lines

Diff 34331

View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

View Options

native/native_rust_library/src/lib.rs

View Options

services/identity/src/grpc_services/authenticated.rs

View Options

services/identity/src/grpc_utils.rs

View Options

shared/protos/identity_authenticated.proto

View Options

shared/protos/identity_client.proto

[identity] Move X3DH message types to auth protoClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34331

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

native/native_rust_library/src/lib.rs

services/identity/src/grpc_services/authenticated.rs

services/identity/src/grpc_utils.rs

shared/protos/identity_authenticated.proto

shared/protos/identity_client.proto

[identity] Move X3DH message types to auth proto
ClosedPublic
Actions

Revision Contents
Changeset List