Page MenuHomePhabricator
Differential D9931

[identity] Move Logout and DeleteUser RPCs
ClosedPublic
Actions

Authored by bartek on Nov 20 2023, 4:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 21, 9:05 PM
Unknown Object (File)
Tue, Mar 11, 5:22 PM
Unknown Object (File)
Fri, Mar 7, 1:49 AM
Unknown Object (File)
Wed, Mar 5, 3:12 AM
Unknown Object (File)
Wed, Mar 5, 12:31 AM
Unknown Object (File)
Feb 20 2025, 11:39 PM
Unknown Object (File)
Feb 20 2025, 11:39 PM
Unknown Object (File)
Feb 20 2025, 11:39 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMM04526b2637a0: [identity] Move Logout and DeleteUser RPCs
Summary

Moved Logout and DeleteUser RPCs to the authenticated proto. Updated client calls accordingly.

Depends on D9930

Test Plan

Verified that logout is callable via auth client. Verified that DeleteUser deletes item from users table (called this in native commRustModule to verify client working)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Nov 20 2023, 4:23 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 20 2023, 4:23 AM
Harbormaster failed remote builds in B24271: Diff 33409!Nov 20 2023, 4:49 AM
bartek updated this revision to Diff 33413.Nov 20 2023, 4:54 AM

Fix import

Harbormaster completed remote builds in B24275: Diff 33413.Nov 20 2023, 6:04 AM
bartek published this revision for review.Nov 23 2023, 1:48 AM
bartek added a child revision: D9957: [identity] Move X3DH RPCs to auth proto.Nov 23 2023, 1:53 AM
varun requested changes to this revision.Nov 27 2023, 10:24 AM

can you please also update the gRPC web codegen files?

This revision now requires changes to proceed.Nov 27 2023, 10:24 AM
bartek requested review of this revision.Nov 28 2023, 8:04 AM
In D9931#292402, @varun wrote:

can you please also update the gRPC web codegen files?

I updated these in D10064

bartek mentioned this in D10064: [web] Update gRPC-web generated files.Nov 29 2023, 12:08 AM
varun accepted this revision.Nov 29 2023, 6:10 AM
This revision is now accepted and ready to land.Nov 29 2023, 6:10 AM
Closed by commit rCOMM04526b2637a0: [identity] Move Logout and DeleteUser RPCs (authored by bartek). · Explain WhyDec 4 2023, 2:43 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM04526b2637a0: [identity] Move Logout and DeleteUser RPCs.

Revision Contents
Changeset List

PathSize
native/
native_rust_library/
src/
21 lines
services/
identity/
src/
91 lines
grpc_services/
38 lines
shared/
protos/
5 lines
24 lines

Diff 34175

View Options

native/native_rust_library/src/lib.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { useModalContext } from 'lib/components/modal-provider.react.js';
import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js'; import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js';
import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js'; import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js';
import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js'; import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js';
import css from './keyserver-selection-list.css'; import css from './keyserver-selection-list.css';
import AddKeyserverModal from '../modals/keyserver-selection/add-keyserver-modal.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
function KeyserverSelectionList(): React.Node { function KeyserverSelectionList(): React.Node {
const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> = const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> =
useSelector(selectedKeyserversSelector); useSelector(selectedKeyserversSelector);
const selectedKeyservers = React.useMemo( const selectedKeyservers = React.useMemo(
() => () =>
selectedKeyserverInfos.map( selectedKeyserverInfos.map(
({ keyserverAdminUserInfo, keyserverInfo }) => ( ({ keyserverAdminUserInfo, keyserverInfo }) => (
<KeyserverSelectionListItem <KeyserverSelectionListItem
key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`} key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`}
keyserverAdminUserInfo={keyserverAdminUserInfo} keyserverAdminUserInfo={keyserverAdminUserInfo}
keyserverInfo={keyserverInfo} keyserverInfo={keyserverInfo}
/> />
), ),
), ),
[selectedKeyserverInfos], [selectedKeyserverInfos],
); );
const { pushModal } = useModalContext();
const onClickAddKeyserver = React.useCallback(
() => pushModal(<AddKeyserverModal />),
[pushModal],
);
const keyserverSelectionList = React.useMemo( const keyserverSelectionList = React.useMemo(
() => ( () => (
<div className={css.container}> <div className={css.container}>
<div className={css.headerContainer}>
<h4 className={css.header}>Keyservers</h4> <h4 className={css.header}>Keyservers</h4>
<div onClick={onClickAddKeyserver}>
<SWMansionIcon
icon="plus-small"
size={26}
className={css.addButton}
/>
</div>
</div>
{selectedKeyservers} {selectedKeyservers}
</div> </div>
), ),
[selectedKeyservers], [onClickAddKeyserver, selectedKeyservers],
); );
return keyserverSelectionList; return keyserverSelectionList;
} }
export default KeyserverSelectionList; export default KeyserverSelectionList;
View Options

services/identity/src/client_service.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { useModalContext } from 'lib/components/modal-provider.react.js';
import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js'; import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js';
import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js'; import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js';
import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js'; import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js';
import css from './keyserver-selection-list.css'; import css from './keyserver-selection-list.css';
import AddKeyserverModal from '../modals/keyserver-selection/add-keyserver-modal.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
function KeyserverSelectionList(): React.Node { function KeyserverSelectionList(): React.Node {
const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> = const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> =
useSelector(selectedKeyserversSelector); useSelector(selectedKeyserversSelector);
const selectedKeyservers = React.useMemo( const selectedKeyservers = React.useMemo(
() => () =>
selectedKeyserverInfos.map( selectedKeyserverInfos.map(
({ keyserverAdminUserInfo, keyserverInfo }) => ( ({ keyserverAdminUserInfo, keyserverInfo }) => (
<KeyserverSelectionListItem <KeyserverSelectionListItem
key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`} key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`}
keyserverAdminUserInfo={keyserverAdminUserInfo} keyserverAdminUserInfo={keyserverAdminUserInfo}
keyserverInfo={keyserverInfo} keyserverInfo={keyserverInfo}
/> />
), ),
), ),
[selectedKeyserverInfos], [selectedKeyserverInfos],
); );
const { pushModal } = useModalContext();
const onClickAddKeyserver = React.useCallback(
() => pushModal(<AddKeyserverModal />),
[pushModal],
);
const keyserverSelectionList = React.useMemo( const keyserverSelectionList = React.useMemo(
() => ( () => (
<div className={css.container}> <div className={css.container}>
<div className={css.headerContainer}>
<h4 className={css.header}>Keyservers</h4> <h4 className={css.header}>Keyservers</h4>
<div onClick={onClickAddKeyserver}>
<SWMansionIcon
icon="plus-small"
size={26}
className={css.addButton}
/>
</div>
</div>
{selectedKeyservers} {selectedKeyservers}
</div> </div>
), ),
[selectedKeyservers], [onClickAddKeyserver, selectedKeyservers],
); );
return keyserverSelectionList; return keyserverSelectionList;
} }
export default KeyserverSelectionList; export default KeyserverSelectionList;
View Options

services/identity/src/grpc_services/authenticated.rs

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { useModalContext } from 'lib/components/modal-provider.react.js';
import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js'; import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js';
import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js'; import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js';
import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js'; import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js';
import css from './keyserver-selection-list.css'; import css from './keyserver-selection-list.css';
import AddKeyserverModal from '../modals/keyserver-selection/add-keyserver-modal.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
function KeyserverSelectionList(): React.Node { function KeyserverSelectionList(): React.Node {
const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> = const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> =
useSelector(selectedKeyserversSelector); useSelector(selectedKeyserversSelector);
const selectedKeyservers = React.useMemo( const selectedKeyservers = React.useMemo(
() => () =>
selectedKeyserverInfos.map( selectedKeyserverInfos.map(
({ keyserverAdminUserInfo, keyserverInfo }) => ( ({ keyserverAdminUserInfo, keyserverInfo }) => (
<KeyserverSelectionListItem <KeyserverSelectionListItem
key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`} key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`}
keyserverAdminUserInfo={keyserverAdminUserInfo} keyserverAdminUserInfo={keyserverAdminUserInfo}
keyserverInfo={keyserverInfo} keyserverInfo={keyserverInfo}
/> />
), ),
), ),
[selectedKeyserverInfos], [selectedKeyserverInfos],
); );
const { pushModal } = useModalContext();
const onClickAddKeyserver = React.useCallback(
() => pushModal(<AddKeyserverModal />),
[pushModal],
);
const keyserverSelectionList = React.useMemo( const keyserverSelectionList = React.useMemo(
() => ( () => (
<div className={css.container}> <div className={css.container}>
<div className={css.headerContainer}>
<h4 className={css.header}>Keyservers</h4> <h4 className={css.header}>Keyservers</h4>
<div onClick={onClickAddKeyserver}>
<SWMansionIcon
icon="plus-small"
size={26}
className={css.addButton}
/>
</div>
</div>
{selectedKeyservers} {selectedKeyservers}
</div> </div>
), ),
[selectedKeyservers], [onClickAddKeyserver, selectedKeyservers],
); );
return keyserverSelectionList; return keyserverSelectionList;
} }
export default KeyserverSelectionList; export default KeyserverSelectionList;
View Options

shared/protos/identity_authenticated.proto

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import { useModalContext } from 'lib/components/modal-provider.react.js';
import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js'; import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js';
import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js'; import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js';
import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js'; import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js';
import css from './keyserver-selection-list.css'; import css from './keyserver-selection-list.css';
import AddKeyserverModal from '../modals/keyserver-selection/add-keyserver-modal.react.js';
import { useSelector } from '../redux/redux-utils.js'; import { useSelector } from '../redux/redux-utils.js';
function KeyserverSelectionList(): React.Node { function KeyserverSelectionList(): React.Node {
const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> = const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> =
useSelector(selectedKeyserversSelector); useSelector(selectedKeyserversSelector);
const selectedKeyservers = React.useMemo( const selectedKeyservers = React.useMemo(
() => () =>
selectedKeyserverInfos.map( selectedKeyserverInfos.map(
({ keyserverAdminUserInfo, keyserverInfo }) => ( ({ keyserverAdminUserInfo, keyserverInfo }) => (
<KeyserverSelectionListItem <KeyserverSelectionListItem
key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`} key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`}
keyserverAdminUserInfo={keyserverAdminUserInfo} keyserverAdminUserInfo={keyserverAdminUserInfo}
keyserverInfo={keyserverInfo} keyserverInfo={keyserverInfo}
/> />
), ),
), ),
[selectedKeyserverInfos], [selectedKeyserverInfos],
); );
const { pushModal } = useModalContext();
const onClickAddKeyserver = React.useCallback(
() => pushModal(<AddKeyserverModal />),
[pushModal],
);
const keyserverSelectionList = React.useMemo( const keyserverSelectionList = React.useMemo(
() => ( () => (
<div className={css.container}> <div className={css.container}>
<div className={css.headerContainer}>
<h4 className={css.header}>Keyservers</h4> <h4 className={css.header}>Keyservers</h4>
<div onClick={onClickAddKeyserver}>
<SWMansionIcon
icon="plus-small"
size={26}
className={css.addButton}
/>
</div>
</div>
{selectedKeyservers} {selectedKeyservers}
</div> </div>
), ),
[selectedKeyservers], [onClickAddKeyserver, selectedKeyservers],
); );
return keyserverSelectionList; return keyserverSelectionList;
} }
export default KeyserverSelectionList; export default KeyserverSelectionList;
View Options

shared/protos/identity_client.proto

Loading...