Paths

Table of Contentst

-
keyserver/addons/rust-node-addon/src/identity_client/
-
addons/
-
rust-node-addon/
-
src/
-
identity_client/
-
mod.rs
-
upload_one_time_keys.rs
-
services/
-
commtest/tests/
-
tests/
-
identity_access_tokens_tests.rs
-
identity_keyserver_tests.rs
-
identity_one_time_key_tests.rs
-
identity_tunnelbroker_tests.rs
-
identity/src/
-
src/
-
client_service.rs
-
shared/protos/
-
protos/
-
identity_client.proto

Differential D9928

[identity] Delete unauthenticated UploadOneTimeKeys RPC
ClosedPublic
Actions

Authored by bartek on Nov 20 2023, 4:15 AM.

Details

Reviewers

varun

Commits

rCOMMa4da1e841133: [identity] Delete unauthenticated UploadOneTimeKeys RPC

Summary

We have UploadOneTimeKeys in both authenticated and unauthenticated proto. I've removed the unauthenticated one and changed the usages to use the authenticated one.

I was curious why this wasn't done earlier, see: https://phab.comm.dev/D9059#267156

Test Plan

Ran Commtest tests changing its endpoint to use the authenticated one.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Nov 20 2023, 4:15 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 20 2023, 4:15 AM

bartek added a child revision: D9929: [identity] Extract insert_into_cache to trait.Nov 20 2023, 4:17 AM

Harbormaster completed remote builds in B24268: Diff 33406.Nov 20 2023, 4:36 AM

bartek published this revision for review.Nov 20 2023, 4:50 AM

just one question inline

services/commtest/tests/identity_access_tokens_tests.rs
38 ↗	(On Diff #33406)	should we modify this test to use the auth client instead of deleting it altogether?

This revision is now accepted and ready to land.Nov 20 2023, 11:35 AM

bartek added inline comments.Dec 4 2023, 2:39 AM

services/commtest/tests/identity_access_tokens_tests.rs
38 ↗	(On Diff #33406)	I deleted it because it was duplicated. Look at `upload_one_time_keys()` test one file above. I think this was Jon's rebase issue when he was introducing it.

Closed by commit rCOMMa4da1e841133: [identity] Delete unauthenticated UploadOneTimeKeys RPC (authored by bartek). · Explain WhyDec 4 2023, 2:43 AM

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMMa4da1e841133: [identity] Delete unauthenticated UploadOneTimeKeys RPC.

Revision Contents
Changeset List

Path

Size

keyserver/

addons/

rust-node-addon/

src/

identity_client/

mod.rs

3 lines

upload_one_time_keys.rs

6 lines

services/

commtest/

tests/

identity_access_tokens_tests.rs

31 lines

identity_keyserver_tests.rs

23 lines

identity_one_time_key_tests.rs

12 lines

identity_tunnelbroker_tests.rs

33 lines

identity/

src/

client_service.rs

42 lines

shared/

protos/

identity_client.proto

13 lines

Diff 34171

View Options

keyserver/addons/rust-node-addon/src/identity_client/mod.rs

	// @flow			// @flow

	import * as React from 'react';			import * as React from 'react';

				import { useModalContext } from 'lib/components/modal-provider.react.js';
				import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
	import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js';			import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js';
	import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js';			import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js';

	import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js';			import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js';
	import css from './keyserver-selection-list.css';			import css from './keyserver-selection-list.css';
				import AddKeyserverModal from '../modals/keyserver-selection/add-keyserver-modal.react.js';
	import { useSelector } from '../redux/redux-utils.js';			import { useSelector } from '../redux/redux-utils.js';

	function KeyserverSelectionList(): React.Node {			function KeyserverSelectionList(): React.Node {
	const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> =			const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> =
	useSelector(selectedKeyserversSelector);			useSelector(selectedKeyserversSelector);

	const selectedKeyservers = React.useMemo(			const selectedKeyservers = React.useMemo(
	() =>			() =>
	selectedKeyserverInfos.map(			selectedKeyserverInfos.map(
	({ keyserverAdminUserInfo, keyserverInfo }) => (			({ keyserverAdminUserInfo, keyserverInfo }) => (
	<KeyserverSelectionListItem			<KeyserverSelectionListItem
	key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`}			key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`}
	keyserverAdminUserInfo={keyserverAdminUserInfo}			keyserverAdminUserInfo={keyserverAdminUserInfo}
	keyserverInfo={keyserverInfo}			keyserverInfo={keyserverInfo}
	/>			/>
	),			),
	),			),
	[selectedKeyserverInfos],			[selectedKeyserverInfos],
	);			);

				const { pushModal } = useModalContext();

				const onClickAddKeyserver = React.useCallback(
				() => pushModal(<AddKeyserverModal />),
				[pushModal],
				);

	const keyserverSelectionList = React.useMemo(			const keyserverSelectionList = React.useMemo(
	() => (			() => (
	<div className={css.container}>			<div className={css.container}>
				<div className={css.headerContainer}>
	<h4 className={css.header}>Keyservers</h4>			<h4 className={css.header}>Keyservers</h4>
				<div onClick={onClickAddKeyserver}>
				<SWMansionIcon
				icon="plus-small"
				size={26}
				className={css.addButton}
				/>
				</div>
				</div>
	{selectedKeyservers}			{selectedKeyservers}
	</div>			</div>
	),			),
	[selectedKeyservers],			[onClickAddKeyserver, selectedKeyservers],
	);			);

	return keyserverSelectionList;			return keyserverSelectionList;
	}			}

	export default KeyserverSelectionList;			export default KeyserverSelectionList;

View Options

keyserver/addons/rust-node-addon/src/identity_client/upload_one_time_keys.rs

	// @flow			// @flow

	import * as React from 'react';			import * as React from 'react';

				import { useModalContext } from 'lib/components/modal-provider.react.js';
				import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
	import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js';			import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js';
	import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js';			import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js';

	import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js';			import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js';
	import css from './keyserver-selection-list.css';			import css from './keyserver-selection-list.css';
				import AddKeyserverModal from '../modals/keyserver-selection/add-keyserver-modal.react.js';
	import { useSelector } from '../redux/redux-utils.js';			import { useSelector } from '../redux/redux-utils.js';

	function KeyserverSelectionList(): React.Node {			function KeyserverSelectionList(): React.Node {
	const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> =			const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> =
	useSelector(selectedKeyserversSelector);			useSelector(selectedKeyserversSelector);

	const selectedKeyservers = React.useMemo(			const selectedKeyservers = React.useMemo(
	() =>			() =>
	selectedKeyserverInfos.map(			selectedKeyserverInfos.map(
	({ keyserverAdminUserInfo, keyserverInfo }) => (			({ keyserverAdminUserInfo, keyserverInfo }) => (
	<KeyserverSelectionListItem			<KeyserverSelectionListItem
	key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`}			key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`}
	keyserverAdminUserInfo={keyserverAdminUserInfo}			keyserverAdminUserInfo={keyserverAdminUserInfo}
	keyserverInfo={keyserverInfo}			keyserverInfo={keyserverInfo}
	/>			/>
	),			),
	),			),
	[selectedKeyserverInfos],			[selectedKeyserverInfos],
	);			);

				const { pushModal } = useModalContext();

				const onClickAddKeyserver = React.useCallback(
				() => pushModal(<AddKeyserverModal />),
				[pushModal],
				);

	const keyserverSelectionList = React.useMemo(			const keyserverSelectionList = React.useMemo(
	() => (			() => (
	<div className={css.container}>			<div className={css.container}>
				<div className={css.headerContainer}>
	<h4 className={css.header}>Keyservers</h4>			<h4 className={css.header}>Keyservers</h4>
				<div onClick={onClickAddKeyserver}>
				<SWMansionIcon
				icon="plus-small"
				size={26}
				className={css.addButton}
				/>
				</div>
				</div>
	{selectedKeyservers}			{selectedKeyservers}
	</div>			</div>
	),			),
	[selectedKeyservers],			[onClickAddKeyserver, selectedKeyservers],
	);			);

	return keyserverSelectionList;			return keyserverSelectionList;
	}			}

	export default KeyserverSelectionList;			export default KeyserverSelectionList;

View Options

services/commtest/tests/identity_access_tokens_tests.rs

	// @flow			// @flow

	import * as React from 'react';			import * as React from 'react';

				import { useModalContext } from 'lib/components/modal-provider.react.js';
				import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
	import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js';			import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js';
	import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js';			import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js';

	import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js';			import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js';
	import css from './keyserver-selection-list.css';			import css from './keyserver-selection-list.css';
				import AddKeyserverModal from '../modals/keyserver-selection/add-keyserver-modal.react.js';
	import { useSelector } from '../redux/redux-utils.js';			import { useSelector } from '../redux/redux-utils.js';

	function KeyserverSelectionList(): React.Node {			function KeyserverSelectionList(): React.Node {
	const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> =			const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> =
	useSelector(selectedKeyserversSelector);			useSelector(selectedKeyserversSelector);

	const selectedKeyservers = React.useMemo(			const selectedKeyservers = React.useMemo(
	() =>			() =>
	selectedKeyserverInfos.map(			selectedKeyserverInfos.map(
	({ keyserverAdminUserInfo, keyserverInfo }) => (			({ keyserverAdminUserInfo, keyserverInfo }) => (
	<KeyserverSelectionListItem			<KeyserverSelectionListItem
	key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`}			key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`}
	keyserverAdminUserInfo={keyserverAdminUserInfo}			keyserverAdminUserInfo={keyserverAdminUserInfo}
	keyserverInfo={keyserverInfo}			keyserverInfo={keyserverInfo}
	/>			/>
	),			),
	),			),
	[selectedKeyserverInfos],			[selectedKeyserverInfos],
	);			);

				const { pushModal } = useModalContext();

				const onClickAddKeyserver = React.useCallback(
				() => pushModal(<AddKeyserverModal />),
				[pushModal],
				);

	const keyserverSelectionList = React.useMemo(			const keyserverSelectionList = React.useMemo(
	() => (			() => (
	<div className={css.container}>			<div className={css.container}>
				<div className={css.headerContainer}>
	<h4 className={css.header}>Keyservers</h4>			<h4 className={css.header}>Keyservers</h4>
				<div onClick={onClickAddKeyserver}>
				<SWMansionIcon
				icon="plus-small"
				size={26}
				className={css.addButton}
				/>
				</div>
				</div>
	{selectedKeyservers}			{selectedKeyservers}
	</div>			</div>
	),			),
	[selectedKeyservers],			[onClickAddKeyserver, selectedKeyservers],
	);			);

	return keyserverSelectionList;			return keyserverSelectionList;
	}			}

	export default KeyserverSelectionList;			export default KeyserverSelectionList;

View Options

services/commtest/tests/identity_keyserver_tests.rs

	// @flow			// @flow

	import * as React from 'react';			import * as React from 'react';

				import { useModalContext } from 'lib/components/modal-provider.react.js';
				import SWMansionIcon from 'lib/components/SWMansionIcon.react.js';
	import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js';			import { selectedKeyserversSelector } from 'lib/selectors/keyserver-selectors.js';
	import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js';			import type { SelectedKeyserverInfo } from 'lib/types/keyserver-types.js';

	import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js';			import KeyserverSelectionListItem from './keyserver-selection-list-item.react.js';
	import css from './keyserver-selection-list.css';			import css from './keyserver-selection-list.css';
				import AddKeyserverModal from '../modals/keyserver-selection/add-keyserver-modal.react.js';
	import { useSelector } from '../redux/redux-utils.js';			import { useSelector } from '../redux/redux-utils.js';

	function KeyserverSelectionList(): React.Node {			function KeyserverSelectionList(): React.Node {
	const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> =			const selectedKeyserverInfos: $ReadOnlyArray<SelectedKeyserverInfo> =
	useSelector(selectedKeyserversSelector);			useSelector(selectedKeyserversSelector);

	const selectedKeyservers = React.useMemo(			const selectedKeyservers = React.useMemo(
	() =>			() =>
	selectedKeyserverInfos.map(			selectedKeyserverInfos.map(
	({ keyserverAdminUserInfo, keyserverInfo }) => (			({ keyserverAdminUserInfo, keyserverInfo }) => (
	<KeyserverSelectionListItem			<KeyserverSelectionListItem
	key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`}			key={`${keyserverAdminUserInfo.id}${keyserverInfo.urlPrefix}`}
	keyserverAdminUserInfo={keyserverAdminUserInfo}			keyserverAdminUserInfo={keyserverAdminUserInfo}
	keyserverInfo={keyserverInfo}			keyserverInfo={keyserverInfo}
	/>			/>
	),			),
	),			),
	[selectedKeyserverInfos],			[selectedKeyserverInfos],
	);			);

				const { pushModal } = useModalContext();

				const onClickAddKeyserver = React.useCallback(
				() => pushModal(<AddKeyserverModal />),
				[pushModal],
				);

	const keyserverSelectionList = React.useMemo(			const keyserverSelectionList = React.useMemo(
	() => (			() => (
	<div className={css.container}>			<div className={css.container}>
				<div className={css.headerContainer}>
	<h4 className={css.header}>Keyservers</h4>			<h4 className={css.header}>Keyservers</h4>
				<div onClick={onClickAddKeyserver}>
				<SWMansionIcon
				icon="plus-small"
				size={26}
				className={css.addButton}
				/>
				</div>
				</div>
	{selectedKeyservers}			{selectedKeyservers}
	</div>			</div>
	),			),
	[selectedKeyservers],			[onClickAddKeyserver, selectedKeyservers],
	);			);

	return keyserverSelectionList;			return keyserverSelectionList;
	}			}

	export default KeyserverSelectionList;			export default KeyserverSelectionList;