Page MenuHomePhabricator

[identity] Delete unauthenticated UploadOneTimeKeys RPC
ClosedPublic

Authored by bartek on Nov 20 2023, 4:15 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 5:10 AM
Unknown Object (File)
Mon, Oct 28, 12:25 AM
Unknown Object (File)
Mon, Oct 21, 2:38 AM
Unknown Object (File)
Fri, Oct 18, 6:16 AM
Unknown Object (File)
Fri, Oct 18, 6:16 AM
Unknown Object (File)
Fri, Oct 18, 6:08 AM
Unknown Object (File)
Oct 5 2024, 2:18 AM
Unknown Object (File)
Sep 29 2024, 2:12 AM
Subscribers

Details

Summary

We have UploadOneTimeKeys in both authenticated and unauthenticated proto. I've removed the unauthenticated one and changed the usages to use the authenticated one.

I was curious why this wasn't done earlier, see: https://phab.comm.dev/D9059#267156

Test Plan

Ran Commtest tests changing its endpoint to use the authenticated one.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek held this revision as a draft.
bartek published this revision for review.Nov 20 2023, 4:50 AM

just one question inline

services/commtest/tests/identity_access_tokens_tests.rs
38 ↗(On Diff #33406)

should we modify this test to use the auth client instead of deleting it altogether?

This revision is now accepted and ready to land.Nov 20 2023, 11:35 AM
services/commtest/tests/identity_access_tokens_tests.rs
38 ↗(On Diff #33406)

I deleted it because it was duplicated. Look at upload_one_time_keys() test one file above.
I think this was Jon's rebase issue when he was introducing it.