[identity] Delete unauthenticated UploadOneTimeKeys RPC
ClosedPublic
Actions

Authored by bartek on Nov 20 2023, 4:15 AM.

Details

Reviewers

varun

Commits

rCOMMa4da1e841133: [identity] Delete unauthenticated UploadOneTimeKeys RPC

Summary

We have UploadOneTimeKeys in both authenticated and unauthenticated proto. I've removed the unauthenticated one and changed the usages to use the authenticated one.

I was curious why this wasn't done earlier, see: https://phab.comm.dev/D9059#267156

Test Plan

Ran Commtest tests changing its endpoint to use the authenticated one.

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

bartek created this revision.Nov 20 2023, 4:15 AM

bartek held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptNov 20 2023, 4:15 AM

bartek added a child revision: D9929: [identity] Extract insert_into_cache to trait.Nov 20 2023, 4:17 AM

Harbormaster completed remote builds in B24268: Diff 33406.Nov 20 2023, 4:36 AM

bartek published this revision for review.Nov 20 2023, 4:50 AM

just one question inline

services/commtest/tests/identity_access_tokens_tests.rs
38	should we modify this test to use the auth client instead of deleting it altogether?

This revision is now accepted and ready to land.Nov 20 2023, 11:35 AM

bartek added inline comments.Dec 4 2023, 2:39 AM

services/commtest/tests/identity_access_tokens_tests.rs
38	I deleted it because it was duplicated. Look at `upload_one_time_keys()` test one file above. I think this was Jon's rebase issue when he was introducing it.