Details

Reviewers

varun
ashoat

Commits

rCOMM5e1f6dcf67a3: Rename identity_client.proto to identity_unauthenticated.proto

Summary

Resolves ENG-5690.
Renamed:

Proto file
Proto package name
Rust module names
gRPC web file names

Depends on D10429

Test Plan

Built identity, tunnelbroker, grpc_clients, rust-node-addon, native_rust_library, commtest.
CI should pass.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bartek created this revision.Dec 21 2023, 10:49 AM

bartek held this revision as a draft.

Herald added a subscriber: tomek. · View Herald TranscriptDec 21 2023, 10:49 AM

Harbormaster failed remote builds in B25282: Diff 34919!Dec 21 2023, 11:02 AM

Fix import

Add missing rename

Harbormaster failed remote builds in B25286: Diff 34923!Dec 21 2023, 11:33 AM

Harbormaster completed remote builds in B25289: Diff 34926.Dec 21 2023, 12:24 PM

I think we should stick to either "unauth/auth" or "authenticated/unauthenticated" everywhere: in file names, package and module names. Mixing long and short form doesn't feel right. I vote for the short form.

In D10430#301664, @bartek wrote:

I think we should stick to either "unauth/auth" or "authenticated/unauthenticated" everywhere: in file names, package and module names. Mixing long and short form doesn't feel right. I vote for the short form.

I agree

will mentioned this in D10438: [services] [6/n] authentication for search websocket server.Dec 22 2023, 7:11 AM

varun accepted this revision.Dec 22 2023, 8:08 AM

varun added inline comments.

web/scripts/codegen-identity-grpc.sh
20 ↗	(On Diff #34926)	should we change all of these to `unauth` if we're going to use short form exclusively?

This revision is now accepted and ready to land.Dec 22 2023, 8:08 AM

bartek added inline comments.Jan 5 2024, 2:13 AM

web/scripts/codegen-identity-grpc.sh
20 ↗	(On Diff #34926)	Yeah, I'll go with auth/unauth everywhere

Use short auth/unauth everywhere

bartek added a child revision: D10573: Update gRPC-web generated files.Jan 8 2024, 2:18 AM

Harbormaster failed remote builds in B25583: Diff 35350!Jan 8 2024, 2:43 AM

This revision was landed with ongoing or failed builds.Jan 9 2024, 1:23 AM

Closed by commit rCOMM5e1f6dcf67a3: Rename identity_client.proto to identity_unauthenticated.proto (authored by bartek). · Explain Why

This revision was automatically updated to reflect the committed changes.

bartek added a commit: rCOMM5e1f6dcf67a3: Rename identity_client.proto to identity_unauthenticated.proto.

ashoat mentioned this in D10584: [lib][native][web] Expose identity API by using a context.Jan 10 2024, 7:24 AM

Rename identity_client.proto to identity_unauthenticated.proto
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 35418

.github/workflows/identity_tests.yml

native/native_rust_library/src/lib.rs

services/commtest/src/identity/device.rs

services/commtest/tests/identity_access_tokens_tests.rs

services/commtest/tests/identity_prekey_tests.rs

services/identity/build.rs

services/identity/src/client_service.rs

services/identity/src/constants.rs

services/identity/src/grpc_services/authenticated.rs

services/identity/src/grpc_services/mod.rs

shared/grpc_clients/build.rs

shared/grpc_clients/src/identity/device.rs

shared/grpc_clients/src/identity/mod.rs

shared/grpc_clients/src/identity/unauthenticated/mod.rs

shared/protos/identity_auth.proto

shared/protos/identity_authenticated.proto

shared/protos/identity_client.proto

shared/protos/identity_unauth.proto

web/grpc/identity-service-client-wrapper.js

web/protobufs/identity-auth-client.cjs

web/protobufs/identity-auth-client.cjs.flow

web/protobufs/identity-auth-structs.cjs

web/protobufs/identity-auth-structs.cjs.flow

web/protobufs/identity-client.cjs

web/protobufs/identity-client.cjs.flow

web/protobufs/identity-structs.cjs

web/protobufs/identity-structs.cjs.flow

web/protobufs/identity-unauth-structs.cjs

web/protobufs/identity-unauth-structs.cjs.flow

web/protobufs/identity-unauth.cjs

web/protobufs/identity-unauth.cjs.flow

web/scripts/codegen-identity-grpc.sh

Rename identity_client.proto to identity_unauthenticated.protoClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35418

.github/workflows/identity_tests.yml

native/native_rust_library/src/lib.rs

services/commtest/src/identity/device.rs

services/commtest/tests/identity_access_tokens_tests.rs

services/commtest/tests/identity_prekey_tests.rs

services/identity/build.rs

services/identity/src/client_service.rs

services/identity/src/constants.rs

services/identity/src/grpc_services/authenticated.rs

services/identity/src/grpc_services/mod.rs

shared/grpc_clients/build.rs

shared/grpc_clients/src/identity/device.rs

shared/grpc_clients/src/identity/mod.rs

shared/grpc_clients/src/identity/unauthenticated/mod.rs

shared/protos/identity_auth.proto

shared/protos/identity_authenticated.proto

shared/protos/identity_client.proto

shared/protos/identity_unauth.proto

web/grpc/identity-service-client-wrapper.js

web/protobufs/identity-auth-client.cjs

web/protobufs/identity-auth-client.cjs.flow

web/protobufs/identity-auth-structs.cjs

web/protobufs/identity-auth-structs.cjs.flow

web/protobufs/identity-client.cjs

web/protobufs/identity-client.cjs.flow

web/protobufs/identity-structs.cjs

web/protobufs/identity-structs.cjs.flow

web/protobufs/identity-unauth-structs.cjs

web/protobufs/identity-unauth-structs.cjs.flow

web/protobufs/identity-unauth.cjs

web/protobufs/identity-unauth.cjs.flow

web/scripts/codegen-identity-grpc.sh

Rename identity_client.proto to identity_unauthenticated.proto
ClosedPublic
Actions

Revision Contents
Changeset List