Paths

Table of Contentst

Differential D10583

[lib][native][web] Move some types and basic functions out of action-utils.js
ClosedPublic
Actions

Authored by ashoat on Jan 9 2024, 6:52 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Dec 17, 9:06 AM

	Unknown Object (File)
	Fri, Dec 13, 2:17 PM

	Unknown Object (File)
	Tue, Dec 3, 8:53 AM

	Unknown Object (File)
	Mon, Dec 2, 1:46 PM

	Unknown Object (File)
	Tue, Nov 26, 11:23 PM

	Unknown Object (File)
	Nov 23 2024, 9:36 AM

	Unknown Object (File)
	Nov 6 2024, 9:34 AM

	Unknown Object (File)
	Oct 17 2024, 3:03 PM

View All 56 Files

Subscribers

None

Details

Reviewers

inka
varun
tomek

Commits

rCOMMe3407d6feb91: [lib][native][web] Move some types and basic functions out of action-utils.js

Summary

In the following diff, I'll be splitting out the recovery functions out of action-utils.js, in preparation for a later diff where I will turn them into a React Context.

To avoid require cycles, I'm first taking the shared parts that both the new recovery file and the remaining parts of action-utils.js need access to into a separate file.

Depends on D10579

Test Plan

Flow

Diff Detail

Repository

Branch

ashoat/ident2

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Jan 9 2024, 6:52 AM

Harbormaster completed remote builds in B25634: Diff 35436.Jan 9 2024, 7:16 AM

ashoat requested review of this revision.Jan 9 2024, 7:16 AM

tomek accepted this revision.Jan 9 2024, 8:57 AM

inka accepted this revision.Jan 10 2024, 1:01 AM

This revision is now accepted and ready to land.Jan 10 2024, 1:01 AM

Closed by commit rCOMMe3407d6feb91: [lib][native][web] Move some types and basic functions out of action-utils.js (authored by ashoat). · Explain WhyJan 10 2024, 5:43 AM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMe3407d6feb91: [lib][native][web] Move some types and basic functions out of action-utils.js.

ashoat added a child revision: D10596: [lib] Fix typo in policy-acknowledge-utlis.js filename.Jan 10 2024, 10:33 AM

ashoat removed a child revision: D10596: [lib] Fix typo in policy-acknowledge-utlis.js filename.Jan 10 2024, 12:22 PM

Revision Contents
Changeset List

Path

Size

lib/

keyserver-conn/

keyserver-conn-types.js

51 lines

reducers/

calendar-filters-reducer.js

2 lines

calendar-query-reducer.js

2 lines

data-loaded-reducer.js

2 lines

draft-reducer.js

2 lines

enabled-apps-reducer.js

2 lines

entry-reducer.js

2 lines

invite-links-reducer.js

2 lines

keyserver-reducer.js

2 lines

loading-reducer.js

2 lines

message-reducer.js

2 lines

report-store-reducer.js

2 lines

services-access-token-reducer.js

2 lines

theme-reducer.js

2 lines

thread-activity-reducer.js

2 lines

thread-reducer.js

2 lines

user-reducer.js

2 lines

selectors/

loading-selectors.js

2 lines

socket/

socket.react.js

6 lines

utils/

action-utils.js

47 lines

2 lines

sanitization.js

2 lines

native/

account/

resolve-invalidated-cookie.js

2 lines

redux/

2 lines

web/

redux/

crypto-store-reducer.js

2 lines

2 lines

Diff 35436

lib/keyserver-conn/keyserver-conn-types.js

Loading...

lib/reducers/calendar-filters-reducer.js

Loading...

lib/reducers/calendar-query-reducer.js

Loading...

lib/reducers/data-loaded-reducer.js

Loading...

lib/reducers/draft-reducer.js

Loading...

lib/reducers/enabled-apps-reducer.js

Loading...

lib/reducers/entry-reducer.js

Loading...

lib/reducers/invite-links-reducer.js

Loading...

lib/reducers/keyserver-reducer.js

Loading...

lib/reducers/loading-reducer.js

Loading...

lib/reducers/message-reducer.js

Loading...

lib/reducers/report-store-reducer.js

Loading...

lib/reducers/services-access-token-reducer.js

Loading...

lib/reducers/theme-reducer.js

Loading...

lib/reducers/thread-activity-reducer.js

Loading...

lib/reducers/thread-reducer.js

Loading...

lib/reducers/user-reducer.js

Loading...

lib/selectors/loading-selectors.js

Loading...

lib/socket/socket.react.js

Loading...

lib/utils/action-utils.js

Loading...

lib/utils/config.js

Loading...

lib/utils/sanitization.js

Loading...

native/account/resolve-invalidated-cookie.js

Loading...

native/redux/redux-setup.js

Loading...

web/redux/crypto-store-reducer.js

Loading...

web/redux/redux-setup.js

Loading...