Page MenuHomePhabricator
Differential D10438

[services] [6/n] authentication for search websocket server
ClosedPublic
Actions

Authored by will on Dec 22 2023, 12:25 AM.
Tags
None
Referenced Files
F2170867: D10438.diff
Tue, Jul 2, 4:12 PM
Unknown Object (File)
Mon, Jul 1, 10:57 AM
Unknown Object (File)
Mon, Jul 1, 10:57 AM
Unknown Object (File)
Mon, Jul 1, 10:57 AM
Unknown Object (File)
Mon, Jul 1, 10:57 AM
Unknown Object (File)
Mon, Jul 1, 10:57 AM
Unknown Object (File)
Mon, Jul 1, 10:57 AM
Unknown Object (File)
Wed, Jun 12, 2:17 PM
View All 45 Files
Subscribers
ashoat
tomek

Details

Reviewers
bartek
varun
Commits
rCOMM4064a9ada63d: [services] [6/n] authentication for search websocket server
Summary

Authentication verification for websocket connections to search websocket server.
Current implementation maintains connections must provide userID, deviceID, and accessToken.

Depends on D10392

Test Plan

Verified on staging with successful authentication and error messages

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Dec 22 2023, 12:25 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 22 2023, 12:25 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 22 2023, 12:38 AM
Harbormaster failed remote builds in B25312: Diff 34959!
will requested review of this revision.Dec 22 2023, 12:40 AM
will added a comment.Dec 22 2023, 7:11 AM

Just saw

In D10430#301664, @bartek wrote:

I think we should stick to either "unauth/auth" or "authenticated/unauthenticated" everywhere: in file names, package and module names. Mixing long and short form doesn't feel right. I vote for the short form.

Will take that into account

will edited the summary of this revision. (Show Details)Dec 22 2023, 8:12 AM
will added a parent revision: D10392: [services] [5/n] prefix search websocket server.
will added a child revision: D10480: [identity] [lib] [keyserver] [7/n] Add userID to reserved_usernames table in DDB.Dec 28 2023, 9:04 AM
will planned changes to this revision.Jan 3 2024, 1:49 PM
will updated this revision to Diff 35178.Jan 3 2024, 4:30 PM

Rebase with error messages introduced in [5/n]

will added 1 blocking reviewer(s): varun.Jan 3 2024, 4:32 PM
Harbormaster completed remote builds in B25464: Diff 35178.Jan 3 2024, 4:56 PM
varun accepted this revision.Jan 3 2024, 11:53 PM
varun added inline comments.
services/identity/src/websockets/mod.rs
179–331 ↗(On Diff #35178)

this function is very long. can you please create a linear task to break this up?

This revision is now accepted and ready to land.Jan 3 2024, 11:53 PM
will updated this revision to Diff 35578.Jan 12 2024, 11:01 AM

rebase

will added inline comments.Jan 12 2024, 11:04 AM
services/identity/src/websockets/mod.rs
179–331 ↗(On Diff #35178)

Linear task: https://linear.app/comm/issue/ENG-6346/break-up-accept-connection-function-in-identity-websocket-server

Harbormaster completed remote builds in B25729: Diff 35578.Jan 12 2024, 11:20 AM
Closed by commit rCOMM4064a9ada63d: [services] [6/n] authentication for search websocket server (authored by will). · Explain WhyJan 16 2024, 4:08 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMM4064a9ada63d: [services] [6/n] authentication for search websocket server.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
4 lines
websockets/
90 lines
2 lines
35 lines

Diff 35578

View Options

services/identity/src/constants.rs

Loading...
View Options

services/identity/src/websockets/auth.rs

Loading...
View Options

services/identity/src/websockets/errors.rs

Loading...
View Options

services/identity/src/websockets/mod.rs

Loading...