Paths

Table of Contentst

Differential D10651

[rust] Formatting and clippy fixes
ClosedPublic
Actions

Authored by michal on Jan 16 2024, 6:06 AM.

Tags

None

Referenced Files

	F3583616: D10651.diff
	Sun, Dec 29, 3:03 PM

	Unknown Object (File)
	Sat, Dec 28, 3:07 PM

	Unknown Object (File)
	Sat, Dec 28, 3:07 PM

	Unknown Object (File)
	Sat, Dec 28, 3:07 PM

	Unknown Object (File)
	Sat, Dec 28, 3:07 PM

	Unknown Object (File)
	Nov 20 2024, 3:01 PM

	Unknown Object (File)
	Nov 20 2024, 3:01 PM

	Unknown Object (File)
	Oct 22 2024, 1:06 PM

View All 54 Files

Subscribers

Details

Reviewers

bartek
varun
kamil

Commits

rCOMM06db746c75bc: [rust] Formatting and clippy fixes

Summary

ENG-6452 : Lint staged fails on Rust formatting

After nix update, rustfmt started formatting let else which meant that lint-staged was failing. I took this opportunity to also fix some low-hanging clippy fixes.

Test Plan

In each cargo project:

Run cargo fmt
Run cargo clippy
- If there are any quick and safe fixes do them
- If I applied any clippy fixes I also run cargo check && cargo check --tests after that

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

michal created this revision.Jan 16 2024, 6:06 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 16 2024, 6:06 AM

A few arguments were .into() into themselves so the function call was removed. A few unused imports were removed.

services/backup/src/http/handlers/log.rs
56–60 ↗	(On Diff #35667)	Clippy doesn't like repeating names (`Error`) and I think I agree
services/blob/src/database/types.rs
189–217 ↗	(On Diff #35667)	These were changed using a code action provided by rust-analyzer.

Harbormaster completed remote builds in B25798: Diff 35667.Jan 16 2024, 6:24 AM

michal requested review of this revision.Jan 16 2024, 6:24 AM

kamil accepted this revision.Jan 16 2024, 6:37 AM

This revision is now accepted and ready to land.Jan 16 2024, 6:37 AM

Closed by commit rCOMM06db746c75bc: [rust] Formatting and clippy fixes (authored by Michal Gniadek <michal.gniadek@swmansion.com>). · Explain WhyJan 16 2024, 7:03 AM

This revision was automatically updated to reflect the committed changes.

Michal Gniadek <michal.gniadek@swmansion.com> added a commit: rCOMM06db746c75bc: [rust] Formatting and clippy fixes.

Revision Contents
Changeset List

Path

Size

native/

native_rust_library/

src/

2 lines

services/

backup/

src/

2 lines

database/

5 lines

http/

handlers/

8 lines

8 lines

blob/

src/

database/

8 lines

17 lines

http/

handlers/

3 lines

feature-flags/

identity/

src/

4 lines

database/

18 lines

2 lines

1 line

grpc_services/

authenticated.rs

15 lines

reports/

src/

email/

9 lines

report_utils.rs

29 lines

shared/

backup_client/

src/

4 lines

comm-lib/

src/

blob/

3 lines

2 lines

4 lines

database/

6 lines

2 lines

Diff 35670

native/native_rust_library/src/lib.rs

Loading...

services/backup/src/config.rs

Loading...

services/backup/src/database/mod.rs

Loading...

services/backup/src/http/handlers/backup.rs

Loading...

services/backup/src/http/handlers/log.rs

Loading...

services/blob/src/database/client.rs

Loading...

services/blob/src/database/types.rs

Loading...

services/blob/src/http/handlers/blob.rs

Loading...

services/feature-flags/Cargo.lock

Loading...

services/identity/src/database.rs

Loading...

services/identity/src/database/device_list.rs

Loading...

services/identity/src/ddb_utils.rs

Loading...

services/identity/src/error.rs

Loading...

services/identity/src/grpc_services/authenticated.rs

Loading...

services/reports/src/email/mod.rs

Loading...

services/reports/src/report_utils.rs

Loading...

shared/backup_client/src/lib.rs

Loading...

shared/comm-lib/src/blob/client.rs

Loading...

shared/comm-lib/src/blob/types.rs

Loading...

shared/comm-lib/src/database.rs

Loading...

shared/comm-lib/src/database/blob.rs

Loading...

shared/comm-lib/src/tools.rs

Loading...