Page MenuHomePhabricator
Differential D10605

[native] Filepath generation for log and userkeys data
ClosedPublic
Actions

Authored by michal on Jan 11 2024, 7:46 AM.
Tags
None
Referenced Files
F5337298: D10605.id.diff
Wed, Apr 9, 12:40 AM
F5329511: D10605.id35680.diff
Tue, Apr 8, 9:08 PM
F5329101: D10605.id35571.diff
Tue, Apr 8, 9:00 PM
Unknown Object (File)
Mon, Apr 7, 12:03 AM
Unknown Object (File)
Sun, Mar 30, 10:10 AM
Unknown Object (File)
Thu, Mar 13, 2:20 AM
Unknown Object (File)
Mar 2 2025, 10:30 PM
Unknown Object (File)
Feb 28 2025, 10:45 PM
View All 66 Files
Subscribers
ashoat
tomek

Details

Reviewers
marcin
kamil
Commits
rCOMMb0967842639c: [native] Filepath generation for log and userkeys data
Summary

ENG-6216 : Add rust code for getting filepath with compations/logs
Adds two new functions for files used for backup data storage on the device (while they are waiting to be confirmed by backup service): one for logs (with optional attachments file) and the second one for userkeys file.

Additionally changes the functions to take &str (rust::Str) instead of String (rust::String) as we are making a copy of them to std::string immediately and don't need to pass an owned string.

Depends on D10604

Test Plan

Called these functions from rust and got these results:

backup-123-userkeys
backup-123-log-456
backup-123-log-456-attachments

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
native/
android/
app/
src/
cpp/
40 lines
main/
java/
app/
comm/
android/
fbjni/
20 lines
cpp/
CommonCpp/
Tools/
5 lines
ios/
Comm/
32 lines
native_rust_library/
5 lines
13 lines
src/
14 lines

Diff 35680

View Options

native/android/app/src/cpp/PlatformSpecificTools.cpp

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Linespublic:
std::string getMetadata(std::string entry_name) const override; std::string getMetadata(std::string entry_name) const override;
#ifdef EMSCRIPTEN #ifdef EMSCRIPTEN
std::vector<WebThread> getAllThreadsWeb() const override; std::vector<WebThread> getAllThreadsWeb() const override;
void replaceThreadWeb(const WebThread &thread) const override; void replaceThreadWeb(const WebThread &thread) const override;
#else #else
static void clearSensitiveData(); static void clearSensitiveData();
static void initialize(std::string &databasePath); static void initialize(std::string &databasePath);
void createMainCompaction(std::string backupID) const override;
#endif #endif
}; };
} // namespace comm } // namespace comm
View Options

native/android/app/src/main/java/app/comm/android/fbjni/PlatformSpecificTools.java

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Linespublic:
std::string getMetadata(std::string entry_name) const override; std::string getMetadata(std::string entry_name) const override;
#ifdef EMSCRIPTEN #ifdef EMSCRIPTEN
std::vector<WebThread> getAllThreadsWeb() const override; std::vector<WebThread> getAllThreadsWeb() const override;
void replaceThreadWeb(const WebThread &thread) const override; void replaceThreadWeb(const WebThread &thread) const override;
#else #else
static void clearSensitiveData(); static void clearSensitiveData();
static void initialize(std::string &databasePath); static void initialize(std::string &databasePath);
void createMainCompaction(std::string backupID) const override;
#endif #endif
}; };
} // namespace comm } // namespace comm
View Options

native/cpp/CommonCpp/Tools/PlatformSpecificTools.h

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Linespublic:
std::string getMetadata(std::string entry_name) const override; std::string getMetadata(std::string entry_name) const override;
#ifdef EMSCRIPTEN #ifdef EMSCRIPTEN
std::vector<WebThread> getAllThreadsWeb() const override; std::vector<WebThread> getAllThreadsWeb() const override;
void replaceThreadWeb(const WebThread &thread) const override; void replaceThreadWeb(const WebThread &thread) const override;
#else #else
static void clearSensitiveData(); static void clearSensitiveData();
static void initialize(std::string &databasePath); static void initialize(std::string &databasePath);
void createMainCompaction(std::string backupID) const override;
#endif #endif
}; };
} // namespace comm } // namespace comm
View Options

native/ios/Comm/PlatformSpecificTools.mm

Show First 20 Lines • Show All 85 Lines • ▼ Show 20 Linespublic:
std::string getMetadata(std::string entry_name) const override; std::string getMetadata(std::string entry_name) const override;
#ifdef EMSCRIPTEN #ifdef EMSCRIPTEN
std::vector<WebThread> getAllThreadsWeb() const override; std::vector<WebThread> getAllThreadsWeb() const override;
void replaceThreadWeb(const WebThread &thread) const override; void replaceThreadWeb(const WebThread &thread) const override;
#else #else
static void clearSensitiveData(); static void clearSensitiveData();
static void initialize(std::string &databasePath); static void initialize(std::string &databasePath);
void createMainCompaction(std::string backupID) const override;
#endif #endif
}; };
} // namespace comm } // namespace comm
View Options

native/native_rust_library/RustBackupExecutor.h

Loading...
View Options

native/native_rust_library/RustBackupExecutor.cpp

Loading...
View Options

native/native_rust_library/src/lib.rs

Loading...