This diff introduces the block list panel. This component will replace the block list modal.
Linear task: https://linear.app/comm/issue/ENG-5955/flatten-friends-block-list-modals
Details
Details
- Reviewers
atul inka - Commits
- rCOMM1f2b1238d36c: [web] introduce block list panel
Please see the demo video below
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| web/settings/relationship/block-list-panel.react.js | ||
|---|---|---|
| 16 | Most of this logic is taken from BlockListModal. I intentionally decided to not delete the code in BlockListModal because I want to make sure that I can land this diff as is w/o worrying about creating regressions/breaking changes. To make it easy to review tho, I will point out where the duplicated logic is. I updated https://linear.app/comm/issue/ENG-6442/remove-friends-list-modal to track removing BOTH FriendListModal and BlockListModal | |
| 17–24 | I did create a new relationships variable to keep consistent pattern with the FriendListPanel | |
| 26–28 | ||
| 35–38 | ||
Comment Actions
Look good. Personally would've preferred deduplicating BlockListModal, but not sure how involved that would've been.
Comment Actions
Look good. Personally would've preferred deduplicating BlockListModal, but not sure how involved that would've been.
Spoke to @atul IRL about this, but this is necessary in order to land this diff as is w/o causing regressions in prod