Page MenuHomePhabricator

[web] ens resolve usernames in the reaction tooltip
ClosedPublic

Authored by ginsu on Dec 20 2023, 6:06 PM.
Tags
None
Referenced Files
F3377298: D10419.id34889.diff
Wed, Nov 27, 5:01 AM
F3377297: D10419.id34888.diff
Wed, Nov 27, 5:01 AM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Unknown Object (File)
Fri, Nov 15, 8:05 AM
Subscribers

Details

Summary

The reaction tooltip was not properly resoving ens usernames. This diff fixes that issue

Linear task: https://linear.app/comm/issue/ENG-5917/reactions-list-doesnt-appear-to-be-ens-resolved

Test Plan

Please see screenshots below

before:

Screenshot 2024-01-23 at 3.25.53 PM.png (1×3 px, 871 KB)

after:

Screenshot 2024-01-23 at 3.33.56 PM.png (1×3 px, 878 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu requested review of this revision.Dec 20 2023, 6:42 PM
rohan requested changes to this revision.Dec 22 2023, 5:17 PM

Just requesting changes so its back in your queue. Let me know if my testing was missing something

This revision now requires changes to proceed.Dec 22 2023, 5:17 PM

Is there some missing context here? It sounds like @rohan did some testing and things didn't work, but not sure what that testing was

Is there some missing context here? It sounds like @rohan did some testing and things didn't work, but not sure what that testing was

Ah sorry I'll add the context here. @ginsu and I spoke offline - I patched in the stack locally and changed the providers to use goerli instead of mainnet (since I have some ENS names linked to wallet addresses on the testnet).

I verified that the ENS names for my users resolved in my inbox, chat, etc, but when I tried hovering over the reaction tooltip, it only showed the wallet addresses. One thing I noticed was when the useENSNames hook was called in the reaction tooltip, ensCache was always undefined so we'd early return. I wasn't sure if that was the cause for them not resolving in the reaction tooltip for me.

Edit: Not sure if it's helpful. but when I move the AlchemyENSCacheProvider above TooltipProvider in app.react.js, the ENS names are resolved now

Edit: Not sure if it's helpful. but when I move the AlchemyENSCacheProvider above TooltipProvider in app.react.js, the ENS names are resolved now

This is super helpful @rohan! Thanks for taking a look at this! I will update the diff once I can properly sign in w/ eth and better test this out myself. (I actually managed to resolve a lot of my metamask linking issues today)

Is this working & ready for review now?

Is this working & ready for review now?

Yes, updated the diff, test plan + reviewers (previously had rohan but he's no longer here) to reflect the new changes I made

This revision is now accepted and ready to land.Jan 25 2024, 1:11 PM
ginsu edited the test plan for this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Jan 26 2024, 8:37 AM
This revision was automatically updated to reflect the committed changes.