Page MenuHomePhabricator
Differential D10779

[tunnelbroker-messages] Add message type for anonymous session
ClosedPublic
Actions

Authored by bartek on Jan 22 2024, 5:28 AM.
Tags
None
Referenced Files
F2207589: D10779.id36227.diff
Sun, Jul 7, 8:41 AM
F2207515: D10779.id35955.diff
Sun, Jul 7, 8:12 AM
F2207357: D10779.id36237.diff
Sun, Jul 7, 7:27 AM
Unknown Object (File)
Fri, Jul 5, 2:37 PM
Unknown Object (File)
Thu, Jul 4, 2:02 PM
Unknown Object (File)
Thu, Jul 4, 2:40 AM
Unknown Object (File)
Wed, Jul 3, 5:30 PM
Unknown Object (File)
Wed, Jul 3, 7:24 AM
View All 43 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
michal
Commits
rCOMM9e9638c1fa00: [tunnelbroker-messages] Add message type for anonymous session
Summary

Resolves ENG-4694.
Added a counterpart of ConnectionInitializationMessage for unauthenticated devices.

Test Plan

CI, check if everything compiles.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bartek created this revision.Jan 22 2024, 5:28 AM
bartek held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 5:28 AM
bartek added a child revision: D10782: [tunnelbroker] Add support for unauthenticated websocket sessions.Jan 22 2024, 5:32 AM
Harbormaster completed remote builds in B26021: Diff 35955.Jan 22 2024, 5:46 AM
bartek published this revision for review.Jan 22 2024, 6:43 AM
kamil accepted this revision.Jan 25 2024, 3:29 AM
kamil added inline comments.
shared/tunnelbroker_messages/src/messages/session.rs
55 ↗(On Diff #35955)

do we need notify_token for unauthenticated session?

This revision is now accepted and ready to land.Jan 25 2024, 3:29 AM
ashoat added inline comments.Jan 25 2024, 12:35 PM
shared/tunnelbroker_messages/src/messages/session.rs
55 ↗(On Diff #35955)

I can't think of any use case

kamil mentioned this in D10782: [tunnelbroker] Add support for unauthenticated websocket sessions.Jan 26 2024, 9:01 AM
bartek updated this revision to Diff 36227.Jan 29 2024, 1:48 AM

Remove notify_token

Harbormaster completed remote builds in B26234: Diff 36227.Jan 29 2024, 2:07 AM
Closed by commit rCOMM9e9638c1fa00: [tunnelbroker-messages] Add message type for anonymous session (authored by bartek). · Explain WhyJan 29 2024, 2:16 AM
This revision was automatically updated to reflect the committed changes.
bartek added a commit: rCOMM9e9638c1fa00: [tunnelbroker-messages] Add message type for anonymous session.

Revision Contents
Changeset List

PathSize
lib/
types/
tunnelbroker/
1 line
shared/
tunnelbroker_messages/
src/
messages/
2 lines
1 line
14 lines

Diff 36237

View Options

lib/types/tunnelbroker/messages.js

Loading...
View Options

shared/tunnelbroker_messages/src/messages/message_to_device_request_status.rs

Loading...
View Options

shared/tunnelbroker_messages/src/messages/mod.rs

Loading...
View Options

shared/tunnelbroker_messages/src/messages/session.rs

Loading...