Paths

Table of Contentst

-
web/types/
-
types/
-
nav-types.js

Differential D10887

[web] Rename `LoginMethod` -> `WebLoginMethod`
ClosedPublic
Actions

Authored by atul on Jan 31 2024, 9:59 AM.

Tags

None

Referenced Files

	F6265061: D10887.diff
	Fri, Apr 25, 10:23 AM

	Unknown Object (File)
	Fri, Apr 11, 7:16 AM

	Unknown Object (File)
	Feb 18 2025, 12:47 PM

	Unknown Object (File)
	Feb 16 2025, 6:31 PM

	Unknown Object (File)
	Feb 16 2025, 6:31 PM

	Unknown Object (File)
	Feb 16 2025, 6:31 PM

	Unknown Object (File)
	Feb 16 2025, 6:31 PM

	Unknown Object (File)
	Feb 16 2025, 6:30 PM

View All 66 Files

Subscribers

None

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMM909c64b2c984: [web] Rename `LoginMethod` -> `WebLoginMethod`

Summary

Same as previous diff, but for LoginMethod.

Depends on D10886

Test Plan

Straightforward rename, used IDE Refactor -> Rename tool

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 31 2024, 9:59 AM

atul edited the summary of this revision. (Show Details)Jan 31 2024, 10:01 AM

atul added a parent revision: D10886: [web] Rename `NavigationTab` -> `WebNavigationTab`.

atul added a child revision: D10888: [web] Rename `NavigationSettingsSection` -> `WebNavigationSettingsSection`.

include validator

Harbormaster completed remote builds in B26343: Diff 36411.Jan 31 2024, 10:17 AM

Harbormaster completed remote builds in B26350: Diff 36421.Jan 31 2024, 10:30 AM

atul requested review of this revision.Jan 31 2024, 10:30 AM

ginsu accepted this revision.Jan 31 2024, 10:40 AM

This revision is now accepted and ready to land.Jan 31 2024, 10:40 AM

Closed by commit rCOMM909c64b2c984: [web] Rename `LoginMethod` -> `WebLoginMethod` (authored by atul). · Explain WhyJan 31 2024, 12:17 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM909c64b2c984: [web] Rename `LoginMethod` -> `WebLoginMethod`.

Revision Contents
Changeset List

Path

Size

web/

types/

4 lines

Diff 36411

web/types/nav-types.js

	Show First 20 Lines • Show All 69 Lines • ▼ Show 20 Lines		if (!isViewer && startsCluster) {
	height += authorNameHeight;			height += authorNameHeight;
	}			}
	if (endsCluster) {			if (endsCluster) {
	height += clusterEndHeight;			height += clusterEndHeight;
	}			}
	if (textMessageSendFailed(item)) {			if (textMessageSendFailed(item)) {
	height += failedSendHeight;			height += failedSendHeight;
	}			}
	const label = getMessageLabel(item.hasBeenEdited, threadInfo);			const label = getMessageLabel(item.hasBeenEdited, threadInfo.id);
	if (item.threadCreatedFromMessage \|\| Object.keys(item.reactions).length > 0) {			if (item.threadCreatedFromMessage \|\| Object.keys(item.reactions).length > 0) {
	height +=			height +=
	inlineEngagementStyle.height +			inlineEngagementStyle.height +
	inlineEngagementStyle.marginTop +			inlineEngagementStyle.marginTop +
	inlineEngagementStyle.marginBottom;			inlineEngagementStyle.marginBottom;
	} else if (label) {			} else if (label) {
	height +=			height +=
	inlineEngagementLabelStyle.height +			inlineEngagementLabelStyle.height +
	▲ Show 20 Lines • Show All 367 Lines • Show Last 20 Lines