[web][lib] Move `WebNavInfo` type dependencies to `lib`
ClosedPublic
Actions

Authored by atul on Jan 31 2024, 6:18 PM.

Details

Reviewers

ashoat
ginsu
tomek

Commits

rCOMM6dcea8cc31c7: [web][lib] Move `WebNavInfo` type dependencies to `lib`

Summary

Move WebLoginMethod, WebNavigationChatMode, WebNavigationSettingsSection, WebNavigationTab, and associated validators to lib

Depends on D10890

Test Plan

Used IDE Refactor -> Move tool and read through changes carefully. Also trusting flow and CI.

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Jan 31 2024, 6:18 PM

atul added a child revision: D10892: [lib] Move `WebNavInfo` to `lib`.Jan 31 2024, 6:31 PM

Harbormaster completed remote builds in B26353: Diff 36424.Jan 31 2024, 6:39 PM

atul requested review of this revision.Jan 31 2024, 6:39 PM

Looks good, could you lmk when you land this. I know I made some changes to WebNavigationSettingsSection in my stacks (D10824) so just want to make sure to make changes to that if you land this diff first

ginsu accepted this revision.Jan 31 2024, 7:01 PM

This revision is now accepted and ready to land.Jan 31 2024, 7:01 PM

In D10891#314115, @ginsu wrote:

Looks good, could you lmk when you land this. I know I made some changes to WebNavigationSettingsSection in my stacks (D10824) so just want to make sure to make changes to that if you land this diff first

Just landed!

Closed by commit rCOMM6dcea8cc31c7: [web][lib] Move `WebNavInfo` type dependencies to `lib`. · Explain WhyJan 31 2024, 8:17 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM6dcea8cc31c7: [web][lib] Move `WebNavInfo` type dependencies to `lib`.