Page MenuHomePhabricator
Differential D10900

[web] introduce member list sidebar header
ClosedPublic
Actions

Authored by ginsu on Jan 31 2024, 1:21 PM.
Tags
None
Referenced Files
F3352428: D10900.diff
Sat, Nov 23, 5:52 AM
Unknown Object (File)
Sun, Nov 10, 1:02 AM
Unknown Object (File)
Fri, Nov 8, 10:03 PM
Unknown Object (File)
Fri, Nov 8, 7:15 PM
Unknown Object (File)
Fri, Nov 8, 7:15 PM
Unknown Object (File)
Fri, Nov 8, 7:15 PM
Unknown Object (File)
Oct 3 2024, 4:52 PM
Unknown Object (File)
Oct 3 2024, 4:52 PM
View All 62 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
ashoat
Commits
rCOMMdced8049e4c4: [web] introduce member list sidebar header
Summary

This diff introduces the member list sidebar header component.

For context here is what the figma designs for this look like

Screenshot 2024-01-31 at 4.24.05 PM.png (434×992 px, 39 KB)

Linear task: https://linear.app/comm/issue/ENG-5975/introduce-new-member-list-section

Depends on D10899

Test Plan

Please see the demo video below:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Jan 31 2024, 1:21 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 31 2024, 1:21 PM
ginsu edited the summary of this revision. (Show Details)Jan 31 2024, 1:26 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D10899: [web] introduce member list sidebar provider.
ginsu attached a referenced file: F1103313: Screenshot 2024-01-31 at 4.24.05 PM.png. (Show Details)
ginsu added a reviewer: ashoat.

Making @ashoat blocking since we are introducing new copy

web/chat/member-list-sidebar/member-list-sidebar-header.react.js
37 ↗(On Diff #36474)

New copy is introduced

Harbormaster completed remote builds in B26379: Diff 36474.Jan 31 2024, 1:40 PM
ginsu requested review of this revision.Jan 31 2024, 1:40 PM
ginsu added a child revision: D10901: [web] introduce threadMembersSelectorForThread.Jan 31 2024, 2:03 PM
ashoat resigned from this revision.Jan 31 2024, 2:08 PM

Copy looks good! Thanks for adding me

inka accepted this revision.Feb 1 2024, 4:18 AM
This revision is now accepted and ready to land.Feb 1 2024, 4:18 AM
ginsu added a child revision: D10919: [lib] introduce useMembersGroupedByRole.Feb 1 2024, 3:01 PM
ginsu removed a child revision: D10901: [web] introduce threadMembersSelectorForThread.Feb 1 2024, 3:05 PM
ginsu updated this revision to Diff 36660.Feb 5 2024, 3:43 PM

rebase before landing

This revision was landed with ongoing or failed builds.Feb 5 2024, 3:45 PM
Closed by commit rCOMMdced8049e4c4: [web] introduce member list sidebar header (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMdced8049e4c4: [web] introduce member list sidebar header.
Harbormaster completed remote builds in B26525: Diff 36660.Feb 5 2024, 4:01 PM
ginsu removed a child revision: D10919: [lib] introduce useMembersGroupedByRole.Feb 6 2024, 3:14 PM

Revision Contents
Changeset List

PathSize
web/
chat/
member-list-sidebar/
28 lines
52 lines

Diff 36660

View Options

web/chat/member-list-sidebar/member-list-sidebar-header.css

Loading...
View Options

web/chat/member-list-sidebar/member-list-sidebar-header.react.js

Loading...