Page MenuHomePhabricator
Differential D10920

[web] make useSortedENSResolvedUsers more permissive
ClosedPublic
Actions

Authored by ginsu on Feb 1 2024, 3:09 PM.
Tags
None
Referenced Files
F3591822: D10920.id36753.diff
Mon, Dec 30, 1:13 PM
Unknown Object (File)
Sun, Dec 29, 11:28 AM
Unknown Object (File)
Thu, Dec 26, 7:09 PM
Unknown Object (File)
Thu, Dec 26, 7:09 PM
Unknown Object (File)
Thu, Dec 26, 7:09 PM
Unknown Object (File)
Sun, Dec 15, 11:50 AM
Unknown Object (File)
Nov 10 2024, 5:47 PM
Unknown Object (File)
Nov 8 2024, 10:03 PM
View All 66 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMcf34b97ebde6: [web] make useSortedENSResolvedUsers more permissive
Summary

In the next diff we are going to want to use useSortedENSResolvedUsers to sort + resolve the thread members infos just like we did with the add friend list modal. However, right now useSortedENSResolvedUsers is currently typed so thread members can't use this hook since they use RelativeMemberInfo.

This diff updates useSortedENSResolvedUsers so that it can be used in both places

Test Plan

flow + confirmed that users are sorted correctly in the add users list + thread members list

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Feb 1 2024, 3:09 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 1 2024, 3:09 PM
ginsu edited the summary of this revision. (Show Details)Feb 1 2024, 3:11 PM
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D10919: [lib] introduce useMembersGroupedByRole.
Harbormaster completed remote builds in B26440: Diff 36558.Feb 1 2024, 3:29 PM
ginsu requested review of this revision.Feb 1 2024, 3:29 PM
ginsu added a child revision: D10921: [web] introduce RoleGroupMemberList.Feb 1 2024, 3:42 PM
atul accepted this revision.Feb 5 2024, 10:53 AM
atul added inline comments.
web/settings/relationship/user-list-hooks.js
8 ↗(On Diff #36558)

Do we need isViewer, or could we just do something like:

type BaseUserInfo = { +username?: ?string, ... };

Looks like we only call useENSNames and it looks like that only needs username

312b1d.png (398×994 px, 82 KB)

This revision is now accepted and ready to land.Feb 5 2024, 10:53 AM
atul attached a referenced file: F1116861: 312b1d.png. (Show Details)Feb 5 2024, 10:53 AM
ginsu added inline comments.Feb 5 2024, 4:08 PM
web/settings/relationship/user-list-hooks.js
8 ↗(On Diff #36558)

Because we are using the stringForUser function we need isViewer as well

Screenshot 2024-02-05 at 7.07.30 PM.png (794×2 px, 328 KB)

Screenshot 2024-02-05 at 7.06.35 PM.png (540×832 px, 73 KB)

ginsu attached a referenced file: F1118109: Screenshot 2024-02-05 at 7.06.35 PM.png. (Show Details)Feb 5 2024, 4:08 PM
ginsu attached a referenced file: F1118110: Screenshot 2024-02-05 at 7.07.30 PM.png. (Show Details)
ginsu removed a parent revision: D10919: [lib] introduce useMembersGroupedByRole.Feb 6 2024, 3:03 PM
ginsu edited the summary of this revision. (Show Details)
ginsu removed a child revision: D10921: [web] introduce RoleGroupMemberList.
ginsu updated this revision to Diff 36753.Feb 6 2024, 3:06 PM
ginsu edited the summary of this revision. (Show Details)

rebase before landing

This revision was landed with ongoing or failed builds.Feb 6 2024, 3:09 PM
Closed by commit rCOMMcf34b97ebde6: [web] make useSortedENSResolvedUsers more permissive (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMcf34b97ebde6: [web] make useSortedENSResolvedUsers more permissive.
Harbormaster completed remote builds in B26597: Diff 36753.Feb 6 2024, 3:24 PM
ginsu added a child revision: D10921: [web] introduce RoleGroupMemberList.Feb 6 2024, 4:37 PM
ginsu removed a child revision: D10921: [web] introduce RoleGroupMemberList.Feb 6 2024, 4:38 PM

Revision Contents
Changeset List

PathSize
web/
settings/
relationship/
14 lines

Diff 36754

View Options

web/settings/relationship/user-list-hooks.js

Loading...