When we start using CSAT, we can use identityInvalidSessionDowngrade (D10962) to check if session downgrade is valid. Until then we have to use the old logic, because CSAT is always undefined, so we cannot check if identity session changed, and if the same user logs backin, the session downgrade may be incorrectly considered valid
Details
Tested that if using CSAT, and a different CSAT is present in state and in preRequestUserState, then this code returns
Tested that if currentUserInfo and preRequestUserState.currentUserInfo are the same, and CSAT is present in state and in preRequestUserState are the same, and a user is logged in and the action is trying to downgrade the session - then resetUserSpecificStateOnIdentityActions is called and action goes to the next reducers
Tested that if using CSAT currentUserInfo and preRequestUserState.currentUserInfo are different, then this code returns
Tested that if not using CSAT, this code correctly disregards an action performing an invalid session downgrade
Diff Detail
- Repository
- rCOMM Comm
- Branch
- inka/invalidSessionDowngrade
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
native/redux/redux-setup.js | ||
---|---|---|
165–179 ↗ | (On Diff #36672) | It might be cleaner if we moved usingCommServicesAccessToken check into identityInvalidSessionDowngrade and "redirect" to invalidSessionDowngrade inside it. |
Address review - move usingCommServicesAccessToken check into identityInvalidSessionDowngrade