Page MenuHomePhabricator
Differential D10999

[native] fix change role modal border radius style
ClosedPublic
Actions

Authored by ginsu on Feb 8 2024, 11:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 1:06 PM
Unknown Object (File)
Tue, Oct 22, 9:02 AM
Unknown Object (File)
Tue, Oct 22, 8:36 AM
Unknown Object (File)
Tue, Oct 22, 8:36 AM
Unknown Object (File)
Tue, Oct 22, 8:36 AM
Unknown Object (File)
Tue, Oct 22, 8:36 AM
Unknown Object (File)
Sep 10 2024, 11:58 PM
Unknown Object (File)
Sep 6 2024, 10:38 PM
View All 74 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMMee64c3efb470: [native] fix change role modal border radius style
Summary

When a user went into the change role modal in light mode the bottom corners had a border radius that showed a darker background. To fix this I added the cardStyleInterpolator option to the changeRolesScreenOptions so that it is just a full screen modal w/o any border radius. (This is also the same convention we use in the create community full screen modal)

Linear task: https://linear.app/comm/issue/ENG-6354/lower-rounded-corners-in-change-role-screen-on-mobile-need-to-be

Depends on D11002

Test Plan

Please see demo video below

before:

after:

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Feb 8 2024, 11:19 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 8 2024, 11:19 AM
ginsu edited the summary of this revision. (Show Details)Feb 8 2024, 11:21 AM
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2024, 11:24 AM
Harbormaster failed remote builds in B26668: Diff 36878!
ginsu updated this revision to Diff 36885.Feb 8 2024, 12:01 PM
ginsu edited the summary of this revision. (Show Details)

update

ginsu edited the summary of this revision. (Show Details)Feb 8 2024, 12:04 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D11002: [native] move transitionPreset into shared navigation options file.
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2024, 12:04 PM
Harbormaster failed remote builds in B26675: Diff 36885!
ginsu requested review of this revision.Feb 8 2024, 12:05 PM

will make sure ci passes before landing

atul accepted this revision.Feb 8 2024, 12:27 PM
This revision is now accepted and ready to land.Feb 8 2024, 12:27 PM
ginsu updated this revision to Diff 36943.Feb 9 2024, 9:00 AM
ginsu edited the test plan for this revision. (Show Details)

rebase with ci fix

Harbormaster completed remote builds in B26717: Diff 36943.Feb 9 2024, 9:15 AM
Closed by commit rCOMMee64c3efb470: [native] fix change role modal border radius style (authored by ginsu). · Explain WhyFeb 9 2024, 12:52 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMee64c3efb470: [native] fix change role modal border radius style.

Revision Contents
Changeset List

PathSize
native/
chat/
6 lines

Diff 36943

View Options

native/chat/chat.react.js

Loading...