Page MenuHomePhabricator
Differential D11002

[native] move transitionPreset into shared navigation options file
ClosedPublic
Actions

Authored by ginsu on Feb 8 2024, 11:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 24, 12:20 AM
Unknown Object (File)
Mon, Jun 24, 12:17 AM
Unknown Object (File)
Thu, Jun 20, 1:16 AM
Unknown Object (File)
Tue, Jun 11, 10:07 AM
Unknown Object (File)
Tue, Jun 11, 10:07 AM
Unknown Object (File)
Tue, Jun 11, 10:07 AM
Unknown Object (File)
Apr 4 2024, 5:33 AM
Unknown Object (File)
Apr 4 2024, 5:33 AM
View All 26 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
Commits
rCOMM1fff1eebc97d: [native] move transitionPreset into shared navigation options file
Summary

Move diff, I am planning to use transitionPreset in another react navigator to fix the change roles screen. Instead of duplicating the logic, we should move transitionPreset into the shared options file

Linear task: https://linear.app/comm/issue/ENG-6354/lower-rounded-corners-in-change-role-screen-on-mobile-need-to-be

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Feb 8 2024, 11:56 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 8 2024, 11:56 AM
ginsu edited the summary of this revision. (Show Details)Feb 8 2024, 11:57 AM
ginsu added reviewers: atul, inka.
ginsu retitled this revision from move transitionPreset into shared navigation options file to [native] move transitionPreset into shared navigation options file.
ginsu published this revision for review.Feb 8 2024, 12:00 PM

will make sure ci passes before landing

native/navigation/options.js
28 ↗(On Diff #36883)

This is the only change I made here: we needed this to be typed so flow would be happy

Harbormaster failed remote builds in B26673: Diff 36883!Feb 8 2024, 12:00 PM
ginsu added a child revision: D10999: [native] fix change role modal border radius style.Feb 8 2024, 12:04 PM
ginsu updated this revision to Diff 36942.Feb 9 2024, 9:00 AM

rebase with ci fix

Harbormaster completed remote builds in B26716: Diff 36942.Feb 9 2024, 9:18 AM
ginsu added inline comments.Feb 9 2024, 10:48 AM
native/navigation/options.js
28 ↗(On Diff #36942)

This is the only change I made here: we needed this to be typed so flow would be happy

atul accepted this revision.Feb 9 2024, 12:43 PM

Seems like straightforward move + flow annotation

This revision is now accepted and ready to land.Feb 9 2024, 12:43 PM
Closed by commit rCOMM1fff1eebc97d: [native] move transitionPreset into shared navigation options file (authored by ginsu). · Explain WhyFeb 9 2024, 12:52 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1fff1eebc97d: [native] move transitionPreset into shared navigation options file.

Revision Contents
Changeset List

PathSize
native/
navigation/
36 lines
30 lines

Diff 36953

View Options

native/navigation/options.js

Loading...
View Options

native/navigation/root-navigator.react.js

Loading...