Page MenuHomePhabricator
Differential D11028

[terraform] Remove is-dev conditionals for DDB tables
ClosedPublic
Actions

Authored by bartek on Feb 12 2024, 12:27 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 20, 3:49 PM
Unknown Object (File)
Sun, Apr 20, 5:00 AM
Unknown Object (File)
Sat, Apr 19, 2:06 PM
Unknown Object (File)
Fri, Apr 18, 7:52 PM
Unknown Object (File)
Fri, Apr 18, 9:52 AM
Unknown Object (File)
Wed, Apr 9, 12:44 AM
Unknown Object (File)
Tue, Apr 8, 7:56 PM
Unknown Object (File)
Sat, Mar 29, 8:24 AM
View All 82 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
Commits
rCOMMe4c8ec1585a4: [terraform] Remove is-dev conditionals for DDB tables
Summary

Resolves ENG-4545.

  • The identity-users-opaque2 table was dev-only and unused. Introduced in D7241 and removed in D7534
  • The walletAddress-index was never enabled on remote. So wallet login was working on dev only.
Test Plan

Terraform plan for staging and prod.

Diff Detail

Repository
rCOMM Comm
Branch
barthap/tf-tables
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
services/
terraform/
modules/
shared/
61 lines

Diff 36970

View Options

services/terraform/modules/shared/dynamodb.tf

#import "CommMMKV.h" #import "CommMMKV.h"
#import "../../cpp/CommonCpp/CryptoTools/Tools.h" #import "../../cpp/CommonCpp/CryptoTools/Tools.h"
#import "CommSecureStore.h" #import "CommSecureStore.h"
#import "Logger.h" #import "Logger.h"
#import "Tools.h" #import "Tools.h"
#import <Foundation/Foundation.h> #import <Foundation/Foundation.h>
#import <MMKV.h> #import <MMKV.h>
#import <MMKVCore/MMKV.h>
// Core MMKV C++ implementation and Android wrapper have public `lock` and
// `unlock` methods while Obj-C wrapper doesn't. However Obj-C wrapper has
// private instance variable of type `mmkv::MMKV *`. Interface redeclaration
// below lets us access it. This pattern is hacky but it is well known in
// Obj-C and used in our codebase in CommSecureStore.
@interface MMKV () {
@public
mmkv::MMKV *m_mmkv;
}
@end
namespace comm { namespace comm {
const int mmkvEncryptionKeySize = 16; const int mmkvEncryptionKeySize = 16;
const int mmkvIDsize = 8; const int mmkvIDsize = 8;
const std::string secureStoreMMKVEncryptionKeyID = "comm.mmkvEncryptionKey"; const std::string secureStoreMMKVEncryptionKeyID = "comm.mmkvEncryptionKey";
const std::string secureStoreMMKVIdentifierKeyID = "comm.mmkvID"; const std::string secureStoreMMKVIdentifierKeyID = "comm.mmkvID";
static NSString *mmkvEncryptionKey; static NSString *mmkvEncryptionKey;
static NSString *mmkvIdentifier; static NSString *mmkvIdentifier;
MMKV *getMMKVInstance(NSString *mmkvID, NSString *encryptionKey) { MMKV *getMMKVInstance(NSString *mmkvID, NSString *encryptionKey) {
MMKV *mmkv = MMKV *mmkv =
[MMKV mmkvWithID:mmkvID [MMKV mmkvWithID:mmkvID
cryptKey:[encryptionKey dataUsingEncoding:NSUTF8StringEncoding] cryptKey:[encryptionKey dataUsingEncoding:NSUTF8StringEncoding]
mode:MMKVMultiProcess]; mode:MMKVMultiProcess];
if (!mmkv) { if (!mmkv) {
throw std::runtime_error("Failed to instantiate MMKV object."); throw std::runtime_error("Failed to instantiate MMKV object.");
} }
return mmkv; return mmkv;
} }
CommMMKV::ScopedCommMMKVLock::ScopedCommMMKVLock() {
CommMMKV::initialize();
MMKV *mmkv = getMMKVInstance(mmkvIdentifier, mmkvEncryptionKey);
mmkv->m_mmkv->lock();
}
CommMMKV::ScopedCommMMKVLock::~ScopedCommMMKVLock() {
MMKV *mmkv = getMMKVInstance(mmkvIdentifier, mmkvEncryptionKey);
mmkv->m_mmkv->unlock();
}
void assignInitializationData() { void assignInitializationData() {
std::string encryptionKey = std::string encryptionKey =
crypto::Tools::generateRandomString(mmkvEncryptionKeySize); crypto::Tools::generateRandomString(mmkvEncryptionKeySize);
std::string identifier = crypto::Tools::generateRandomString(mmkvIDsize); std::string identifier = crypto::Tools::generateRandomString(mmkvIDsize);
CommSecureStore::set(secureStoreMMKVEncryptionKeyID, encryptionKey); CommSecureStore::set(secureStoreMMKVEncryptionKeyID, encryptionKey);
CommSecureStore::set(secureStoreMMKVIdentifierKeyID, identifier); CommSecureStore::set(secureStoreMMKVIdentifierKeyID, identifier);
mmkvEncryptionKey = [NSString stringWithCString:encryptionKey.c_str() mmkvEncryptionKey = [NSString stringWithCString:encryptionKey.c_str()
encoding:NSUTF8StringEncoding]; encoding:NSUTF8StringEncoding];
▲ Show 20 Lines • Show All 153 Lines • Show Last 20 Lines