Remove expendable data during compaction creation
ClosedPublic
Actions

Authored by marcin on Feb 9 2024, 7:41 AM.

Details

Reviewers

kamil
michal

Commits

rCOMM63c2dcbc881d: Remove expendable data during compaction creation

Summary

This differential removes olm tables data and metadata table data during main compaction creation.

Test Plan

Repeat final testing plan for main compaction project: https://linear.app/comm/issue/ENG-6146/final-testing-task. Inspect compaction content in tables
plus to ensure that those tables are empty.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

marcin created this revision.Feb 9 2024, 7:41 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 9 2024, 7:41 AM

Harbormaster completed remote builds in B26709: Diff 36932.Feb 9 2024, 8:07 AM

marcin requested review of this revision.Feb 9 2024, 8:07 AM

ashoat added inline comments.Feb 9 2024, 11:08 AM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1732 ↗	(On Diff #36932)	I don't think "expendable" is the right term here

marcin added inline comments.Feb 13 2024, 12:07 AM

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1732 ↗	(On Diff #36932)	I probably misunderstood the word. I will update to `removeDeviceSpecificDataSQL`

kamil accepted this revision.Feb 13 2024, 2:16 AM

This revision is now accepted and ready to land.Feb 13 2024, 2:16 AM

Rename removeExpendableDataSQL -> removeDeviceSpecificDataSQL
Rebase before landing

This revision was landed with ongoing or failed builds.Feb 20 2024, 10:38 AM

Closed by commit rCOMM63c2dcbc881d: Remove expendable data during compaction creation (authored by marcin). · Explain Why

This revision was automatically updated to reflect the committed changes.

marcin added a commit: rCOMM63c2dcbc881d: Remove expendable data during compaction creation.

Harbormaster completed remote builds in B27014: Diff 37376.Feb 20 2024, 11:03 AM

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

SQLiteQueryExecutor.cpp

6 lines

Diff 37377

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Remove expendable data during compaction creationClosedPublicActions