Page MenuHomePhabricator
Differential D11009

Remove expendable data during compaction creation
ClosedPublic
Actions

Authored by marcin on Feb 9 2024, 7:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 7, 3:47 PM
Unknown Object (File)
Mar 1 2025, 6:41 AM
Unknown Object (File)
Feb 27 2025, 9:06 PM
Unknown Object (File)
Feb 27 2025, 9:06 PM
Unknown Object (File)
Feb 27 2025, 9:05 PM
Unknown Object (File)
Feb 26 2025, 7:17 AM
Unknown Object (File)
Feb 26 2025, 7:10 AM
Unknown Object (File)
Jan 20 2025, 5:10 AM
View All 78 Files
Subscribers
ashoat
tomek

Details

Reviewers
kamil
michal
Commits
rCOMM63c2dcbc881d: Remove expendable data during compaction creation
Summary

This differential removes olm tables data and metadata table data during main compaction creation.

Test Plan

Repeat final testing plan for main compaction project: https://linear.app/comm/issue/ENG-6146/final-testing-task. Inspect compaction content in tables
plus to ensure that those tables are empty.

Diff Detail

Repository
rCOMM Comm
Branch
marcin/eng-6728
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

marcin created this revision.Feb 9 2024, 7:41 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 9 2024, 7:41 AM
Harbormaster completed remote builds in B26709: Diff 36932.Feb 9 2024, 8:07 AM
marcin requested review of this revision.Feb 9 2024, 8:07 AM
ashoat added inline comments.Feb 9 2024, 11:08 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1732 ↗(On Diff #36932)

I don't think "expendable" is the right term here

marcin added inline comments.Feb 13 2024, 12:07 AM
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1732 ↗(On Diff #36932)

I probably misunderstood the word. I will update to removeDeviceSpecificDataSQL

kamil accepted this revision.Feb 13 2024, 2:16 AM
This revision is now accepted and ready to land.Feb 13 2024, 2:16 AM
marcin updated this revision to Diff 37376.Feb 20 2024, 10:26 AM
  1. Rename removeExpendableDataSQL -> removeDeviceSpecificDataSQL
  2. Rebase before landing
This revision was landed with ongoing or failed builds.Feb 20 2024, 10:38 AM
Closed by commit rCOMM63c2dcbc881d: Remove expendable data during compaction creation (authored by marcin). · Explain Why
This revision was automatically updated to reflect the committed changes.
marcin added a commit: rCOMM63c2dcbc881d: Remove expendable data during compaction creation.
Harbormaster completed remote builds in B27014: Diff 37376.Feb 20 2024, 11:03 AM

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
DatabaseManagers/
6 lines

Diff 37376

View Options

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Show All 33 Lines
function useCreateDesktopPushSubscription() { function useCreateDesktopPushSubscription() {
const dispatchActionPromise = useDispatchActionPromise(); const dispatchActionPromise = useDispatchActionPromise();
const callSetDeviceToken = useSetDeviceTokenFanout(); const callSetDeviceToken = useSetDeviceTokenFanout();
const staffCanSee = useStaffCanSee(); const staffCanSee = useStaffCanSee();
React.useEffect( React.useEffect(
() => () =>
electron?.onDeviceTokenRegistered?.((token: ?string) => { electron?.onDeviceTokenRegistered?.((token: ?string) => {
dispatchActionPromise( void dispatchActionPromise(
setDeviceTokenActionTypes, setDeviceTokenActionTypes,
callSetDeviceToken(token), callSetDeviceToken(token),
); );
}), }),
[callSetDeviceToken, dispatchActionPromise], [callSetDeviceToken, dispatchActionPromise],
); );
React.useEffect(() => { React.useEffect(() => {
▲ Show 20 Lines • Show All 181 Lines • Show Last 20 Lines