issue: ENG-6416
We want to set the new currentUserInfo after successful with with identity
Details
Details
Dispatched identity login action and checked that the currentUserInfo is set in redux
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
No Lint Coverage - Unit
No Test Coverage
Event Timeline
| lib/reducers/user-reducer.js | ||
|---|---|---|
| 63–66 ↗ | (On Diff #37425) | By doing this we're going to have an empty avatar. This will eventually get fixed by https://linear.app/comm/issue/ENG-4210/handle-avatars-in-currentuserinfo, but in the meantime we can set the avatar on successful keyserver auth from the authoritative keyserver. |
| lib/reducers/user-reducer.js | ||
|---|---|---|
| 63–66 ↗ | (On Diff #37425) | Is making sure that the authoritative keyserver populates the avatar tracked anywhere? Or is this already done? If it's already done, do we have code to make sure ONLY the authoritative keyserver populates the avatar, or is that tracked somewhere? |
Comment Actions
Set avatar and settings on keyserver auth
| lib/reducers/user-reducer.js | ||
|---|---|---|
| 63–66 ↗ | (On Diff #37425) | I will amend this diff |
Comment Actions
keyserverAuth action has a defined currentUserInfo only if it was sent by the authoritative keyserver
| lib/reducers/user-reducer.js | ||
|---|---|---|
| 77 ↗ | (On Diff #37482) | We should check if it is an auth to the authoritative keyserver. |
| lib/reducers/user-reducer.js | ||
|---|---|---|
| 77 ↗ | (On Diff #37482) | Like I said, keyserverAuth action has a defined currentUserInfo only if it was sent by the authoritative keyserver. |