Page MenuHomePhabricator
Differential D11156

[CI] Switch Emscripten CI job to mac runners
ClosedPublic
Actions

Authored by kamil on Feb 23 2024, 6:36 AM.
Tags
None
Referenced Files
F3580730: D11156.diff
Sun, Dec 29, 6:49 AM
Unknown Object (File)
Fri, Dec 20, 1:23 PM
Unknown Object (File)
Fri, Dec 20, 4:17 AM
Unknown Object (File)
Mon, Dec 9, 10:52 AM
Unknown Object (File)
Sat, Dec 7, 1:48 AM
Unknown Object (File)
Wed, Dec 4, 9:26 AM
Unknown Object (File)
Nov 11 2024, 1:36 PM
Unknown Object (File)
Nov 3 2024, 6:55 AM
View All 96 Files
Subscribers
ashoat
tomek

Details

Reviewers
michal
atul
Commits
rCOMM0fa01a00c651: [CI] Switch Emscripten CI job to mac runners
Summary

This reverts D10341 because of issues described in ENG-6879

Reverts D10341

Test Plan
  1. -> should pass
  2. Makes some changes in DB C++ code without committing .wasm changes -> should fail
  3. Run Emscripten locally and commit files -> should pass

See below

Diff Detail

Repository
rCOMM Comm
Branch
fix-wasm-ci
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Feb 23 2024, 6:36 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 23 2024, 6:36 AM
atul published this revision for review.Feb 23 2024, 6:38 AM
atul accepted this revision.
This revision is now accepted and ready to land.Feb 23 2024, 6:38 AM
kamil planned changes to this revision.Feb 23 2024, 6:55 AM

still failing... going to investigate

Harbormaster failed remote builds in B27111: Diff 37519!Feb 23 2024, 6:59 AM
kamil updated this revision to Diff 37521.Feb 23 2024, 7:16 AM

test

This revision is now accepted and ready to land.Feb 23 2024, 7:16 AM
Harbormaster failed remote builds in B27113: Diff 37521!Feb 23 2024, 7:24 AM
kamil updated this revision to Diff 37522.Feb 23 2024, 7:29 AM

add logs

Harbormaster failed remote builds in B27114: Diff 37522!Feb 23 2024, 7:31 AM
kamil updated this revision to Diff 37523.Feb 23 2024, 7:32 AM

fix

kamil updated this revision to Diff 37525.Feb 23 2024, 7:46 AM

okay - now should work

Harbormaster failed remote builds in B27115: Diff 37523!Feb 23 2024, 7:46 AM
kamil updated this revision to Diff 37526.Feb 23 2024, 7:52 AM

this should fail - changing C++ without building wasm

kamil updated this revision to Diff 37527.Feb 23 2024, 7:54 AM

now with built wasm - if succeeds going to land

Harbormaster failed remote builds in B27116: Diff 37525!Feb 23 2024, 7:59 AM
Harbormaster failed remote builds in B27117: Diff 37526!
Harbormaster failed remote builds in B27118: Diff 37527!Feb 23 2024, 8:10 AM
This revision was landed with ongoing or failed builds.Feb 23 2024, 8:11 AM
Closed by commit rCOMM0fa01a00c651: [CI] Switch Emscripten CI job to mac runners (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM0fa01a00c651: [CI] Switch Emscripten CI job to mac runners.
Harbormaster completed remote builds in B27118: Diff 37527.Feb 26 2024, 2:01 PM

Revision Contents
Changeset List

PathSize
.buildkite/
14 lines
web/
scripts/
4 lines

Diff 37525

View Options

.buildkite/emscripten.yml

Loading...
View Options

web/scripts/run_emscripten.sh

Loading...