Page MenuHomePhabricator

[emscripten] Switch Emscripten CI job to autoscaling runners
ClosedPublic

Authored by atul on Dec 14 2023, 10:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Dec 13, 10:19 PM
Unknown Object (File)
Tue, Dec 3, 6:25 PM
Unknown Object (File)
Fri, Nov 29, 3:32 PM
Unknown Object (File)
Nov 18 2024, 9:18 AM
Unknown Object (File)
Nov 14 2024, 12:01 PM
Unknown Object (File)
Nov 14 2024, 12:01 PM
Unknown Object (File)
Nov 14 2024, 12:01 PM
Unknown Object (File)
Nov 14 2024, 12:01 PM
Subscribers
None

Details

Summary

Similar to D10328, D10339, D10340, but for Emscripten.

NOTE: We're using emscripten/emsdk:latest Docker image here instead of rust:1.74.0 like we are for the others.
Test Plan

See if CI passes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 14 2023, 10:46 AM
Harbormaster failed remote builds in B25084: Diff 34651!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 14 2023, 10:49 AM
Harbormaster failed remote builds in B25085: Diff 34652!

last try before giving up

atul edited the test plan for this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 14 2023, 11:03 AM
Harbormaster failed remote builds in B25088: Diff 34655!

call script directly to avoid installing yarn

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 14 2023, 11:06 AM
Harbormaster failed remote builds in B25089: Diff 34656!
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 14 2023, 11:12 AM
Harbormaster failed remote builds in B25090: Diff 34657!

try USE_ES6_IMPORT_META then really give up

actual last try pinning emscripten to version we're using via nix

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 14 2023, 11:24 AM
Harbormaster failed remote builds in B25092: Diff 34659!

non-git way to check file change

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 14 2023, 11:41 AM
Harbormaster failed remote builds in B25093: Diff 34660!
atul requested review of this revision.Dec 14 2023, 1:27 PM

Can you explain why you had to move away from git diff?

kamil requested changes to this revision.Dec 18 2023, 2:44 AM

Looks good but requesting changes to put to your queue and address @ashoat's comment

This revision now requires changes to proceed.Dec 18 2023, 2:44 AM
atul requested review of this revision.Dec 19 2023, 12:53 PM

Can you explain why you had to move away from git diff?

When we're running on the autoscaling runners "directly," we can use git diff because the repo is cloned into the autoscaling environment. However, when we're using the docker plugin, it doesn't re-clone the repo... it just moves the files over.

The files it moves over include .git, but I guess there's more to a git repo being initialized than having the .git? I can research further and give more precise reasoning if necessary, but this works for now.

This revision is now accepted and ready to land.Dec 20 2023, 1:27 AM