[blob] Switch Blob unit tests to autoscaling CI runners
ClosedPublic
Actions

Authored by atul on Dec 13 2023, 12:25 PM.

Details

Reviewers

ginsu
tomek
rohan
bartek
ashoat

Commits

rCOMMc65e52c345e5: [blob] Switch Blob unit tests to autoscaling CI runners

Summary

Switch Blob unit test Buildkite workflow to use autoscaling CI runners.
Context: We discussed this in the retro this morning and I already had a proof of concept for this that I jotted down here: https://linear.app/comm/issue/ENG-5770/office-mba-runner-out-of-storage#comment-d61c38e9

Not actually doing this task right now, just figure I'd diff up what I already had and tested.

Test Plan

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Dec 13 2023, 12:25 PM

atul published this revision for review.Dec 13 2023, 12:39 PM

Harbormaster completed remote builds in B25023: Diff 34571.Dec 13 2023, 12:44 PM

atul edited the test plan for this revision. (Show Details)Dec 13 2023, 12:49 PM

Don't feel strongly and @bartek is blocking anyways

This does mean that we wouldn't catch it if eg. there was some new non-Cargo dependency in the blob service that wasn't in the Nix environment

This does mean that we wouldn't catch it if eg. there was some new non-Cargo dependency in the blob service that wasn't in the Nix environment

We have Docker-based jobs (e.g Blob Build (Docker), CommTest) which are great for catching missing deps. But yeah, they only indicate that it can be missing in Nix too, they don't fail directly

.buildkite/blob_unittests.yml
12 ↗	(On Diff #34571)	We consistently use 1.70 in services but I think this is okay. Let it stay as is

This revision is now accepted and ready to land.Dec 13 2023, 11:58 PM

atul added inline comments.Dec 14 2023, 9:45 AM

.buildkite/blob_unittests.yml
12 ↗	(On Diff #34571)	Ah thanks for the heads up, will leave as is like you suggested. Figure Rust is pretty stable and backwards compatible anyways

This does mean that we wouldn't catch it if eg. there was some new non-Cargo dependency in the blob service that wasn't in the Nix environment

Yeah it's definitely not perfect, but I think it's a pragmatic trade-off. We could also try doing this through the nixOS Docker image, but I'd prefer to stick to simpler rust Docker image for now.

Closed by commit rCOMMc65e52c345e5: [blob] Switch Blob unit tests to autoscaling CI runners (authored by atul). · Explain WhyDec 14 2023, 10:03 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMc65e52c345e5: [blob] Switch Blob unit tests to autoscaling CI runners.

atul mentioned this in D10339: [identity] Switch Identity unit tests to autoscaling CI runners.Dec 14 2023, 10:24 AM

atul mentioned this in D10340: [tunnelbroker] Switch Tunnelbroker unit tests to autoscaling CI runners.Dec 14 2023, 10:35 AM

atul mentioned this in D10341: [emscripten] Switch Emscripten CI job to autoscaling runners.Dec 14 2023, 10:44 AM

atul mentioned this in rCOMM1a7b52ca376b: [tunnelbroker] Switch Tunnelbroker unit tests to autoscaling CI runners.Dec 19 2023, 12:15 AM

atul mentioned this in rCOMM9d4decdf1064: [identity] Switch Identity unit tests to autoscaling CI runners.Dec 19 2023, 1:39 PM

atul mentioned this in rCOMM1c776334d2ce: [emscripten] Switch Emscripten CI job to autoscaling runners.Dec 20 2023, 2:53 PM