Paths

Table of Contentst

Differential D10340

[tunnelbroker] Switch Tunnelbroker unit tests to autoscaling CI runners
ClosedPublic
Actions

Authored by atul on Dec 14 2023, 10:35 AM.

Tags

None

Referenced Files

	F3575444: D10340.id34824.diff
	Sat, Dec 28, 7:33 PM

	F3575443: D10340.id34650.diff
	Sat, Dec 28, 7:33 PM

	F3575442: D10340.id34649.diff
	Sat, Dec 28, 7:33 PM

	F3575441: D10340.id.diff
	Sat, Dec 28, 7:32 PM

	Unknown Object (File)
	Thu, Dec 26, 7:05 PM

	Unknown Object (File)
	Fri, Dec 6, 7:40 PM

	Unknown Object (File)
	Mon, Dec 2, 3:50 AM

	Unknown Object (File)
	Sun, Dec 1, 1:28 PM

View All 67 Files

Subscribers

None

Details

Reviewers

ginsu
tomek
bartek
varun
ashoat
rohan

Commits

rCOMM1a7b52ca376b: [tunnelbroker] Switch Tunnelbroker unit tests to autoscaling CI runners

Summary

Pretty much identical to D10328 and D10339, but for Tunnelbroker.

Context: https://linear.app/comm/issue/ENG-5770/office-mba-runner-out-of-storage#comment-d61c38e9

Test Plan

See if CI passes

e6a7a7.png (924×2 px, 249 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

update herald

atul published this revision for review.Dec 14 2023, 10:41 AM

atul edited the test plan for this revision. (Show Details)

atul mentioned this in D10341: [emscripten] Switch Emscripten CI job to autoscaling runners.Dec 14 2023, 10:44 AM

Harbormaster completed remote builds in B25083: Diff 34650.Dec 14 2023, 11:10 AM

Harbormaster completed remote builds in B25082: Diff 34649.Dec 14 2023, 11:21 AM

I don't think I have enough knowledge here to be helpful, but feel free to re-add me if anything comes up

varun added inline comments.Dec 14 2023, 10:24 PM

.buildkite/tunnelbroker_unittests.yml
4–5 ↗	(On Diff #34650)	again wondering if we really need to install all of this stuff

I think one of the Rust people is a better reviewer for this

bartek added inline comments.Dec 15 2023, 3:06 AM

.buildkite/tunnelbroker_unittests.yml
4–5 ↗	(On Diff #34650)	I think we need protobuf, just to build the project for testing In all services we use `grpc-clients` crate which has `tonic-build` build dependency -> `prost-build` which requires `protoc` executable. And `protoc` is part of protobuf

bartek accepted this revision.Dec 15 2023, 3:06 AM

This revision is now accepted and ready to land.Dec 15 2023, 3:06 AM

bartek mentioned this in D10339: [identity] Switch Identity unit tests to autoscaling CI runners.Dec 15 2023, 3:07 AM

atul added inline comments.Dec 19 2023, 12:10 AM

.buildkite/tunnelbroker_unittests.yml
4–5 ↗	(On Diff #34650)	yeah, get an error from `cargo` if `protoc` isn't available

Closed by commit rCOMM1a7b52ca376b: [tunnelbroker] Switch Tunnelbroker unit tests to autoscaling CI runners (authored by atul). · Explain WhyDec 19 2023, 12:15 AM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM1a7b52ca376b: [tunnelbroker] Switch Tunnelbroker unit tests to autoscaling CI runners.

atul mentioned this in rCOMM1c776334d2ce: [emscripten] Switch Emscripten CI job to autoscaling runners.Dec 20 2023, 2:53 PM

Revision Contents
Changeset List

Path

Size

.buildkite/

tunnelbroker_unittests.yml

15 lines

Diff 34824

.buildkite/tunnelbroker_unittests.yml

Loading...