Paths

Table of Contentst

Differential D11172

[SQLite] implement removing `MessageToDevice` items
ClosedPublic
Actions

Authored by kamil on Feb 26 2024, 2:46 AM.

Tags

None

Referenced Files

	F3113810: D11172.diff
	Thu, Oct 31, 7:25 PM

	Unknown Object (File)
	Tue, Oct 15, 7:19 AM

	Unknown Object (File)
	Tue, Oct 15, 7:19 AM

	Unknown Object (File)
	Tue, Oct 15, 7:19 AM

	Unknown Object (File)
	Sep 4 2024, 5:48 AM

	Unknown Object (File)
	Aug 5 2024, 9:43 AM

	Unknown Object (File)
	Aug 5 2024, 9:43 AM

	Unknown Object (File)
	Aug 5 2024, 9:43 AM

View All 21 Files

Subscribers

Details

Reviewers

marcin
michal

Commits

rCOMMe99a82b2de3c: [SQLite] implement removing `MessageToDevice` items

Summary

Depends on D11171

Test Plan

Tests in D11175.

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Feb 26 2024, 2:46 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 26 2024, 2:46 AM

kamil added a child revision: D11173: [SQLite] implement copying `MessageToDevice` items.Feb 26 2024, 2:47 AM

kamil edited the test plan for this revision. (Show Details)Feb 26 2024, 2:50 AM

Harbormaster failed remote builds in B27161: Diff 37581!Feb 26 2024, 3:20 AM

Harbormaster completed remote builds in B27161: Diff 37581.Feb 26 2024, 3:20 PM

rebase

Harbormaster completed remote builds in B27233: Diff 37692.Feb 29 2024, 6:50 AM

kamil published this revision for review.Mar 1 2024, 12:25 AM

marcin accepted this revision.Mar 1 2024, 2:25 AM

marcin added inline comments.

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp
1747–1749 ↗	(On Diff #37692)	Same as in D11171 - the convention is to use `SQLiteStatementWrapper`. Here, however, error handling is done so no change request.

This revision is now accepted and ready to land.Mar 1 2024, 2:25 AM

address review

Harbormaster completed remote builds in B27305: Diff 37787.Mar 4 2024, 9:53 AM

update error message

Harbormaster completed remote builds in B27320: Diff 37806.Mar 5 2024, 2:47 AM

Closed by commit rCOMMe99a82b2de3c: [SQLite] implement removing `MessageToDevice` items (authored by kamil). · Explain WhyMar 5 2024, 2:58 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMe99a82b2de3c: [SQLite] implement removing `MessageToDevice` items.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

DatabaseManagers/

DatabaseQueryExecutor.h

4 lines

SQLiteQueryExecutor.h

3 lines

SQLiteQueryExecutor.cpp

40 lines

web/

database/

_generated/

comm_query_executor.wasm

Diff 37581

native/cpp/CommonCpp/DatabaseManagers/DatabaseQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.h

Loading...

native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp

Loading...

web/database/_generated/comm_query_executor.wasm

Loading...