Differential D11175

[SQLite] implement tests `MessageToDevice` queries
ClosedPublic
Actions

Authored by kamil on Feb 26 2024, 2:49 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sun, Jan 5, 5:57 AM

	Unknown Object (File)
	Mon, Dec 23, 6:57 PM

	Unknown Object (File)
	Mon, Dec 23, 6:57 PM

	Unknown Object (File)
	Mon, Dec 23, 6:57 PM

	Unknown Object (File)
	Mon, Dec 23, 6:57 PM

	Unknown Object (File)
	Mon, Dec 23, 6:57 PM

	Unknown Object (File)
	Dec 5 2024, 5:32 AM

	Unknown Object (File)
	Dec 5 2024, 5:10 AM

View All 62 Files

Subscribers

Details

Reviewers

marcin
michal

Commits

rCOMM96e0c39d0027: [SQLite] implement tests `MessageToDevice` queries

Summary

Depends on D11174

Test Plan

Run tests

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Feb 26 2024, 2:49 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 26 2024, 2:49 AM

kamil mentioned this in D11170: [SQLite] implement adding `MessageToDevice` to table.Feb 26 2024, 2:50 AM

kamil mentioned this in D11171: [SQLite] implement getting `MessageToDevice` items.

kamil mentioned this in D11172: [SQLite] implement removing `MessageToDevice` items.

kamil mentioned this in D11173: [SQLite] implement copying `MessageToDevice` items.

kamil mentioned this in D11174: [SQLite] add Emscripten bindings to `MessageToDevice` queries.

Harbormaster failed remote builds in B27164: Diff 37584!Feb 26 2024, 3:59 AM

Harbormaster completed remote builds in B27164: Diff 37584.Feb 26 2024, 3:26 PM

rebase

Harbormaster completed remote builds in B27235: Diff 37694.Feb 29 2024, 6:55 AM

kamil published this revision for review.Mar 1 2024, 12:25 AM

marcin accepted this revision.Mar 1 2024, 2:31 AM

marcin added inline comments.

web/database/queries/message-to-device-queries.test.js
67 ↗	(On Diff #37694)	Nit: How about throwing here? I know that in theory this shouldn't occur but if it hypothetically occurs then tests will fail saying that "undefined isn't something else" which could be confusing for developer. Probably all tests files suffer from this problem and could be updated.

This revision is now accepted and ready to land.Mar 1 2024, 2:31 AM

kamil added a child revision: D11241: [web] improve error handling in queries tests.Mar 5 2024, 2:50 AM

kamil added inline comments.Mar 5 2024, 2:56 AM

web/database/queries/message-to-device-queries.test.js
67 ↗	(On Diff #37694)	D11241

Closed by commit rCOMM96e0c39d0027: [SQLite] implement tests `MessageToDevice` queries (authored by kamil). · Explain WhyMar 5 2024, 2:58 AM

This revision was automatically updated to reflect the committed changes.

kamil mentioned this in rCOMMe95580800858: [SQLite] implement adding `MessageToDevice` to table.

kamil mentioned this in rCOMMe663ac61a523: [SQLite] implement getting `MessageToDevice` items.

kamil mentioned this in rCOMMe99a82b2de3c: [SQLite] implement removing `MessageToDevice` items.

kamil mentioned this in rCOMM618971ea9344: [SQLite] add Emscripten bindings to `MessageToDevice` queries.

kamil added a commit: rCOMM96e0c39d0027: [SQLite] implement tests `MessageToDevice` queries.

Revision Contents
Changeset List

Path

Size

web/

database/

queries/

message-to-device-queries.test.js

114 lines

Diff 37817

web/database/queries/message-to-device-queries.test.js

Loading...