[web] fix regression in error handling
ClosedPublic
Actions

Authored by varun on Mar 1 2024, 12:37 PM.

Tags

None

Referenced Files

	F3360162: D11207.id37862.diff
	Sun, Nov 24, 12:21 PM

	F3360155: D11207.id37733.diff
	Sun, Nov 24, 12:20 PM

	Unknown Object (File)
	Tue, Nov 12, 12:07 PM

	Unknown Object (File)
	Tue, Nov 12, 9:17 AM

	Unknown Object (File)
	Tue, Nov 12, 8:07 AM

	Unknown Object (File)
	Tue, Nov 12, 3:02 AM

	Unknown Object (File)
	Oct 10 2024, 12:16 PM

	Unknown Object (File)
	Oct 10 2024, 12:16 PM

View All 48 Files

Subscribers

tomek

Details

Reviewers

ashoat

Commits

rCOMMdadf56db5def: [web] fix regression in error handling

Summary

if the password is wrong we shouldn't display the unknown error text

Depends on D11194

Test Plan

confirmed that the "incorrect username or password" text displays now when the password is incorrect

Diff Detail

Repository

rCOMM Comm

Branch

cors (branched from master)

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

varun created this revision.Mar 1 2024, 12:37 PM

Herald added a subscriber: tomek. · View Herald TranscriptMar 1 2024, 12:37 PM

varun added inline comments.Mar 1 2024, 12:38 PM

web/account/traditional-login-form.react.js
128	task to improve message

Harbormaster completed remote builds in B27256: Diff 37733.Mar 1 2024, 12:53 PM

varun requested review of this revision.Mar 1 2024, 12:53 PM

ashoat accepted this revision.Mar 1 2024, 3:08 PM

This revision is now accepted and ready to land.Mar 1 2024, 3:08 PM

Closed by commit rCOMMdadf56db5def: [web] fix regression in error handling (authored by varun). · Explain WhyMar 5 2024, 12:46 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMdadf56db5def: [web] fix regression in error handling.

Revision Contents
Changeset List

Path

Size

web/

account/

traditional-login-form.react.js

9 lines

Diff 37733

View Options

web/account/traditional-login-form.react.js

[web] fix regression in error handlingClosedPublicActions