Details

Reviewers

tomek
bartek
ashoat

Commits

rCOMM18922ade93a1: [CI] Clean on failure for Emscripten pipeline

Summary

Potential fix for ENG-7092.
Context in ENG-6977 and ENG-6879.

Now this pipeline has two steps:
Emscripten build - build WASM and compare
Clean on failure and Emscripten build - cleans all caches, builds, and compares again

Test Plan

Tested on CI:

Make sure Clean on failure and Emscripten build cleans only when step Emscripten build fails
Make sure Clean on failure and Emscripten build actually cleans files (looked at logs)
On Emscripten build success Clean on failure and Emscripten build should not perform any actions

Diff Detail

Repository

rCOMM Comm

Branch

clean-on-failure

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Mar 5 2024, 4:08 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptMar 5 2024, 4:08 AM

This should clean

Harbormaster failed remote builds in B27329: Diff 37822!Mar 5 2024, 4:29 AM

Harbormaster completed remote builds in B27328: Diff 37821.Mar 5 2024, 4:35 AM

test

Harbormaster failed remote builds in B27331: Diff 37824!Mar 5 2024, 5:24 AM

this should pass

kamil published this revision for review.Mar 5 2024, 5:32 AM

kamil edited the summary of this revision. (Show Details)

kamil edited the test plan for this revision. (Show Details)

kamil added a reviewer: atul. kamil added 1 blocking reviewer(s): michal.

Harbormaster completed remote builds in B27332: Diff 37825.Mar 5 2024, 5:44 AM

michal added inline comments.Mar 5 2024, 5:52 AM

.buildkite/emscripten.yml
19–20	According to the docs, `continue_on_failure: true` won't change the status of the build, so event if this succeeds I think the build will still fail? So that means that `build-db-wasm` and `git diff` lines aren't really needed here if I understand it correctly.

Will run on the MacBook Air (where it was previously failing) here: https://phab.comm.dev/D11245

kamil planned changes to this revision.Mar 15 2024, 5:39 AM

kamil removed reviewers: michal, atul.Mar 20 2025, 5:07 AM

this should fail

Harbormaster failed remote builds in B33792: Diff 47496!Mar 20 2025, 5:40 AM

After making changes in C++ files without committing generated files it failed, executed Clean on failure and Emscripten build which executed clean command also failed, seems fine.