Page MenuHomePhabricator
Differential D11270

[lib] Disable edit button when link secret isn't changed
ClosedPublic
Actions

Authored by tomek on Mar 7 2024, 4:00 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 9, 12:27 AM
Unknown Object (File)
Tue, Apr 8, 8:55 PM
Unknown Object (File)
Tue, Apr 8, 7:58 PM
Unknown Object (File)
Feb 27 2025, 7:11 PM
Unknown Object (File)
Feb 27 2025, 7:11 PM
Unknown Object (File)
Feb 26 2025, 7:17 AM
Unknown Object (File)
Feb 26 2025, 7:11 AM
Unknown Object (File)
Feb 17 2025, 1:20 PM
View All 64 Files
Subscribers
ashoat

Details

Reviewers
inka
atul
Commits
rCOMM756091f20eca: [lib] Disable edit button when link secret isn't changed
Summary

Enable the button only after the link is changed.

https://linear.app/comm/issue/ENG-7149/edit-link-button-is-active-when-a-link-wasnt-changed

Depends on D11269

Test Plan

Open manage links screen on web and native - the button should be disabled. Change the link - the button should become enabled.

Diff Detail

Repository
rCOMM Comm
Branch
fixes
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

PathSize
lib/
hooks/
11 lines
native/
invite-links/
3 lines
web/
invite-links/
manage/
12 lines

Diff 37921

View Options

lib/hooks/invite-links.js

Show All 12 Lines
import { import {
createAsyncMigrate, createAsyncMigrate,
type StorageMigrationFunction, type StorageMigrationFunction,
} from 'lib/shared/create-async-migrate.js'; } from 'lib/shared/create-async-migrate.js';
import type { import type {
KeyserverInfo, KeyserverInfo,
KeyserverStore, KeyserverStore,
} from 'lib/types/keyserver-types.js'; } from 'lib/types/keyserver-types.js';
import { cookieTypes } from 'lib/types/session-types.js';
import { import {
defaultConnectionInfo, defaultConnectionInfo,
type ConnectionInfo, type ConnectionInfo,
} from 'lib/types/socket-types.js'; } from 'lib/types/socket-types.js';
import { parseCookies } from 'lib/utils/cookie-utils.js';
import { isDev } from 'lib/utils/dev-utils.js'; import { isDev } from 'lib/utils/dev-utils.js';
import { import {
generateIDSchemaMigrationOpsForDrafts, generateIDSchemaMigrationOpsForDrafts,
convertDraftStoreToNewIDSchema, convertDraftStoreToNewIDSchema,
} from 'lib/utils/migration-utils.js'; } from 'lib/utils/migration-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import commReduxStorageEngine from './comm-redux-storage-engine.js'; import commReduxStorageEngine from './comm-redux-storage-engine.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines [5]: async state => {
await databaseModule.schedule({ await databaseModule.schedule({
type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS, type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
storeOperations: { draftStoreOperations }, storeOperations: { draftStoreOperations },
}); });
return state; return state;
}, },
[6]: async (state: AppState): Promise<AppState> => {
const params = parseCookies(document.cookie);
let cookie = null;
if (params[cookieTypes.USER]) {
cookie = `${cookieTypes.USER}=${params[cookieTypes.USER]}`;
} else if (params[cookieTypes.ANONYMOUS]) {
cookie = `${cookieTypes.ANONYMOUS}=${params[cookieTypes.ANONYMOUS]}`;
}
return {
...state,
keyserverStore: {
...state.keyserverStore,
keyserverInfos: {
...state.keyserverStore.keyserverInfos,
[ashoatKeyserverID]: {
...state.keyserverStore.keyserverInfos[ashoatKeyserverID],
cookie,
},
},
},
};
},
}; };
const persistWhitelist = [ const persistWhitelist = [
'enabledApps', 'enabledApps',
'deviceID', 'deviceID',
'cryptoStore', 'cryptoStore',
'notifPermissionAlertInfo', 'notifPermissionAlertInfo',
'commServicesAccessToken', 'commServicesAccessToken',
▲ Show 20 Lines • Show All 96 Lines • ▼ Show 20 Linesconst persistConfig: PersistConfig = {
whitelist: isSQLiteSupported() whitelist: isSQLiteSupported()
? persistWhitelist ? persistWhitelist
: [...persistWhitelist, 'draftStore'], : [...persistWhitelist, 'draftStore'],
migrate: (createAsyncMigrate( migrate: (createAsyncMigrate(
migrations, migrations,
{ debug: isDev }, { debug: isDev },
migrateStorageToSQLite, migrateStorageToSQLite,
): any), ): any),
version: 5, version: 6,
transforms: [keyserverStoreTransform], transforms: [keyserverStoreTransform],
}; };
export { persistConfig }; export { persistConfig };
View Options

native/invite-links/manage-public-link-screen.react.js

Show All 12 Lines
import { import {
createAsyncMigrate, createAsyncMigrate,
type StorageMigrationFunction, type StorageMigrationFunction,
} from 'lib/shared/create-async-migrate.js'; } from 'lib/shared/create-async-migrate.js';
import type { import type {
KeyserverInfo, KeyserverInfo,
KeyserverStore, KeyserverStore,
} from 'lib/types/keyserver-types.js'; } from 'lib/types/keyserver-types.js';
import { cookieTypes } from 'lib/types/session-types.js';
import { import {
defaultConnectionInfo, defaultConnectionInfo,
type ConnectionInfo, type ConnectionInfo,
} from 'lib/types/socket-types.js'; } from 'lib/types/socket-types.js';
import { parseCookies } from 'lib/utils/cookie-utils.js';
import { isDev } from 'lib/utils/dev-utils.js'; import { isDev } from 'lib/utils/dev-utils.js';
import { import {
generateIDSchemaMigrationOpsForDrafts, generateIDSchemaMigrationOpsForDrafts,
convertDraftStoreToNewIDSchema, convertDraftStoreToNewIDSchema,
} from 'lib/utils/migration-utils.js'; } from 'lib/utils/migration-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import commReduxStorageEngine from './comm-redux-storage-engine.js'; import commReduxStorageEngine from './comm-redux-storage-engine.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines [5]: async state => {
await databaseModule.schedule({ await databaseModule.schedule({
type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS, type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
storeOperations: { draftStoreOperations }, storeOperations: { draftStoreOperations },
}); });
return state; return state;
}, },
[6]: async (state: AppState): Promise<AppState> => {
const params = parseCookies(document.cookie);
let cookie = null;
if (params[cookieTypes.USER]) {
cookie = `${cookieTypes.USER}=${params[cookieTypes.USER]}`;
} else if (params[cookieTypes.ANONYMOUS]) {
cookie = `${cookieTypes.ANONYMOUS}=${params[cookieTypes.ANONYMOUS]}`;
}
return {
...state,
keyserverStore: {
...state.keyserverStore,
keyserverInfos: {
...state.keyserverStore.keyserverInfos,
[ashoatKeyserverID]: {
...state.keyserverStore.keyserverInfos[ashoatKeyserverID],
cookie,
},
},
},
};
},
}; };
const persistWhitelist = [ const persistWhitelist = [
'enabledApps', 'enabledApps',
'deviceID', 'deviceID',
'cryptoStore', 'cryptoStore',
'notifPermissionAlertInfo', 'notifPermissionAlertInfo',
'commServicesAccessToken', 'commServicesAccessToken',
▲ Show 20 Lines • Show All 96 Lines • ▼ Show 20 Linesconst persistConfig: PersistConfig = {
whitelist: isSQLiteSupported() whitelist: isSQLiteSupported()
? persistWhitelist ? persistWhitelist
: [...persistWhitelist, 'draftStore'], : [...persistWhitelist, 'draftStore'],
migrate: (createAsyncMigrate( migrate: (createAsyncMigrate(
migrations, migrations,
{ debug: isDev }, { debug: isDev },
migrateStorageToSQLite, migrateStorageToSQLite,
): any), ): any),
version: 5, version: 6,
transforms: [keyserverStoreTransform], transforms: [keyserverStoreTransform],
}; };
export { persistConfig }; export { persistConfig };
View Options

web/invite-links/manage/edit-link-modal.react.js

Show All 12 Lines
import { import {
createAsyncMigrate, createAsyncMigrate,
type StorageMigrationFunction, type StorageMigrationFunction,
} from 'lib/shared/create-async-migrate.js'; } from 'lib/shared/create-async-migrate.js';
import type { import type {
KeyserverInfo, KeyserverInfo,
KeyserverStore, KeyserverStore,
} from 'lib/types/keyserver-types.js'; } from 'lib/types/keyserver-types.js';
import { cookieTypes } from 'lib/types/session-types.js';
import { import {
defaultConnectionInfo, defaultConnectionInfo,
type ConnectionInfo, type ConnectionInfo,
} from 'lib/types/socket-types.js'; } from 'lib/types/socket-types.js';
import { parseCookies } from 'lib/utils/cookie-utils.js';
import { isDev } from 'lib/utils/dev-utils.js'; import { isDev } from 'lib/utils/dev-utils.js';
import { import {
generateIDSchemaMigrationOpsForDrafts, generateIDSchemaMigrationOpsForDrafts,
convertDraftStoreToNewIDSchema, convertDraftStoreToNewIDSchema,
} from 'lib/utils/migration-utils.js'; } from 'lib/utils/migration-utils.js';
import { ashoatKeyserverID } from 'lib/utils/validation-utils.js'; import { ashoatKeyserverID } from 'lib/utils/validation-utils.js';
import commReduxStorageEngine from './comm-redux-storage-engine.js'; import commReduxStorageEngine from './comm-redux-storage-engine.js';
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines [5]: async state => {
await databaseModule.schedule({ await databaseModule.schedule({
type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS, type: workerRequestMessageTypes.PROCESS_STORE_OPERATIONS,
storeOperations: { draftStoreOperations }, storeOperations: { draftStoreOperations },
}); });
return state; return state;
}, },
[6]: async (state: AppState): Promise<AppState> => {
const params = parseCookies(document.cookie);
let cookie = null;
if (params[cookieTypes.USER]) {
cookie = `${cookieTypes.USER}=${params[cookieTypes.USER]}`;
} else if (params[cookieTypes.ANONYMOUS]) {
cookie = `${cookieTypes.ANONYMOUS}=${params[cookieTypes.ANONYMOUS]}`;
}
return {
...state,
keyserverStore: {
...state.keyserverStore,
keyserverInfos: {
...state.keyserverStore.keyserverInfos,
[ashoatKeyserverID]: {
...state.keyserverStore.keyserverInfos[ashoatKeyserverID],
cookie,
},
},
},
};
},
}; };
const persistWhitelist = [ const persistWhitelist = [
'enabledApps', 'enabledApps',
'deviceID', 'deviceID',
'cryptoStore', 'cryptoStore',
'notifPermissionAlertInfo', 'notifPermissionAlertInfo',
'commServicesAccessToken', 'commServicesAccessToken',
▲ Show 20 Lines • Show All 96 Lines • ▼ Show 20 Linesconst persistConfig: PersistConfig = {
whitelist: isSQLiteSupported() whitelist: isSQLiteSupported()
? persistWhitelist ? persistWhitelist
: [...persistWhitelist, 'draftStore'], : [...persistWhitelist, 'draftStore'],
migrate: (createAsyncMigrate( migrate: (createAsyncMigrate(
migrations, migrations,
{ debug: isDev }, { debug: isDev },
migrateStorageToSQLite, migrateStorageToSQLite,
): any), ): any),
version: 5, version: 6,
transforms: [keyserverStoreTransform], transforms: [keyserverStoreTransform],
}; };
export { persistConfig }; export { persistConfig };