Page MenuHomePhabricator

Introduce changes to Session.cpp that allow to decrypt with session object alone
ClosedPublic

Authored by marcin on Mar 4 2024, 4:54 AM.
Tags
None
Referenced Files
F3384293: D11233.id38335.diff
Thu, Nov 28, 8:17 PM
Unknown Object (File)
Mon, Nov 25, 6:55 AM
Unknown Object (File)
Mon, Nov 25, 3:21 AM
Unknown Object (File)
Tue, Nov 12, 2:30 AM
Unknown Object (File)
Tue, Nov 12, 1:53 AM
Unknown Object (File)
Wed, Nov 6, 2:48 PM
Unknown Object (File)
Oct 18 2024, 5:17 AM
Unknown Object (File)
Oct 15 2024, 6:37 PM
Subscribers

Details

Summary

This differential refactors CryptoModule and Session objects. The following changes are introduced:

  1. Session object doesn't hold reference to CryptoModule anymore. This reference was just passed in constructor and never used in any method.
  2. Session object can decrypt message independently.
  3. CryptoModule can remove session from its internal map.

All changes above were necessary to enable notifications code to work with sessions objects only.

Test Plan

Text that encrypted notifs work correctly.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

marcin requested review of this revision.Mar 4 2024, 5:10 AM
This revision is now accepted and ready to land.Mar 5 2024, 7:24 AM